From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Qiming Yang <qiming.yang@intel.com>
Subject: [dpdk-test-report] |WARNING| pw55116 [PATCH v3 1/3] net/ice: enable switch filter
Date: Thu, 20 Jun 2019 11:54:56 +0200 (CEST) [thread overview]
Message-ID: <20190620095456.ECF811D04B@dpdk.org> (raw)
In-Reply-To: <20190620053449.32959-2-qiming.yang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55116
_coding style issues_
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#141: FILE: drivers/net/ice/ice_switch_filter.c:27:
+ice_parse_switch_filter(
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.eth_hdr.src_addr[j]'
#205: FILE: drivers/net/ice/ice_switch_filter.c:91:
+ list[t].h_u.eth_hdr.
+ src_addr[j] =
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.eth_hdr.src_addr[j]'
#208: FILE: drivers/net/ice/ice_switch_filter.c:94:
+ list[t].m_u.eth_hdr.
+ src_addr[j] =
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.eth_hdr.dst_addr[j]'
#214: FILE: drivers/net/ice/ice_switch_filter.c:100:
+ list[t].h_u.eth_hdr.
+ dst_addr[j] =
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.eth_hdr.dst_addr[j]'
#217: FILE: drivers/net/ice/ice_switch_filter.c:103:
+ list[t].m_u.eth_hdr.
+ dst_addr[j] =
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.ice_ipv6_ofos_hdr.src_addr[j]'
#287: FILE: drivers/net/ice/ice_switch_filter.c:173:
+ list[t].h_u.ice_ipv6_ofos_hdr.
+ src_addr[j] =
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.ice_ipv6_ofos_hdr.src_addr[j]'
#290: FILE: drivers/net/ice/ice_switch_filter.c:176:
+ list[t].m_u.ice_ipv6_ofos_hdr.
+ src_addr[j] =
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.ice_ipv6_ofos_hdr.dst_addr[j]'
#296: FILE: drivers/net/ice/ice_switch_filter.c:182:
+ list[t].h_u.ice_ipv6_ofos_hdr.
+ dst_addr[j] =
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.ice_ipv6_ofos_hdr.dst_addr[j]'
#299: FILE: drivers/net/ice/ice_switch_filter.c:185:
+ list[t].m_u.ice_ipv6_ofos_hdr.
+ dst_addr[j] =
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].h_u.ice_ipv6_ofos_hdr.hop_limit'
#311: FILE: drivers/net/ice/ice_switch_filter.c:197:
+ list[t].h_u.ice_ipv6_ofos_hdr.
+ hop_limit = ipv6_spec->hdr.hop_limits;
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'list[t].m_u.ice_ipv6_ofos_hdr.hop_limit'
#313: FILE: drivers/net/ice/ice_switch_filter.c:199:
+ list[t].m_u.ice_ipv6_ofos_hdr.
+ hop_limit = UINT8_MAX;
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#460: FILE: drivers/net/ice/ice_switch_filter.c:346:
+/* By now ice switch filter action code implement only
+* supports QUEUE or DROP.
total: 0 errors, 11 warnings, 1 checks, 614 lines checked
parent reply other threads:[~2019-06-20 9:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190620053449.32959-2-qiming.yang@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620095456.ECF811D04B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).