From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B614AA046B for ; Tue, 25 Jun 2019 17:38:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2FEF1BB20; Tue, 25 Jun 2019 17:38:38 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 5D1001BB12; Tue, 25 Jun 2019 17:38:36 +0200 (CEST) In-Reply-To: <20190625153217.24301-25-jasvinder.singh@intel.com> References: <20190625153217.24301-25-jasvinder.singh@intel.com> To: test-report@dpdk.org Cc: Jasvinder Singh Message-Id: <20190625153836.5D1001BB12@dpdk.org> Date: Tue, 25 Jun 2019 17:38:36 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw55348 [PATCH v2 24/28] net/softnic: update softnic tm function X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/55348 _coding style issues_ CHECK:SPACING: No space is necessary after a cast #227: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:625: + (uint32_t *) calloc(RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE, WARNING:LONG_LINE_COMMENT: line over 90 characters #331: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:796: + if (t == RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE - 1) { /*BE Traffic Class*/ WARNING:LONG_LINE: line over 90 characters #332: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:797: + for (q = 0; q < RTE_SCHED_BE_QUEUES_PER_PIPE; q++) { WARNING:LONG_LINE: line over 90 characters #334: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:799: + queue_node_id(n_spp, n_pps, s, p, t, q), WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #341: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:806: + if (status) WARNING:LONG_LINE: line over 90 characters #476: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1054: + if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[0], tokens[35]) != 0) { WARNING:LONG_LINE: line over 90 characters #495: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1070: + if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[1], tokens[37]) != 0) { WARNING:LONG_LINE: line over 90 characters #514: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1086: + if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[2], tokens[39]) != 0) { WARNING:LONG_LINE: line over 90 characters #533: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1102: + if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[3], tokens[41]) != 0) { CHECK:BRACES: braces {} should be used on all arms of this statement #546: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1115: + if (strcmp(tokens[43], "none") == 0) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #548: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1117: + else { WARNING:LONG_LINE: line over 90 characters #549: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1118: + if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[4], tokens[43]) != 0) { CHECK:BRACES: braces {} should be used on all arms of this statement #562: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1131: + if (strcmp(tokens[45], "none") == 0) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #564: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1133: + else { WARNING:LONG_LINE: line over 90 characters #565: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1134: + if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[5], tokens[45]) != 0) { CHECK:BRACES: braces {} should be used on all arms of this statement #578: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1147: + if (strcmp(tokens[47], "none") == 0) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #580: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1149: + else { WARNING:LONG_LINE: line over 90 characters #581: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1150: + if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[6], tokens[47]) != 0) { CHECK:BRACES: braces {} should be used on all arms of this statement #594: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1163: + if (strcmp(tokens[49], "none") == 0) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #596: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1165: + else { WARNING:LONG_LINE: line over 90 characters #597: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1166: + if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[7], tokens[49]) != 0) { CHECK:BRACES: braces {} should be used on all arms of this statement #610: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1179: + if (strcmp(tokens[51], "none") == 0) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #612: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1181: + else { WARNING:LONG_LINE: line over 90 characters #613: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1182: + if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[8], tokens[51]) != 0) { WARNING:LONG_LINE: line over 90 characters #643: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1206: + if (softnic_parser_read_uint32(&p.weight.queue[i], tokens[54 + j]) != 0) { WARNING:LONG_LINE: line over 90 characters #702: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:372: + (n_queues_max * RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE) / RTE_SCHED_QUEUES_PER_PIPE; total: 0 errors, 15 warnings, 11 checks, 818 lines checked