From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2447A046B for ; Thu, 27 Jun 2019 10:07:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAD762F4F; Thu, 27 Jun 2019 10:07:42 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id E152F4C8B; Thu, 27 Jun 2019 10:07:37 +0200 (CEST) In-Reply-To: <130199f8f58fd9be36485bfe6e94c26a6f106fe9.1561620219.git.xuanziyang2@huawei.com> References: <130199f8f58fd9be36485bfe6e94c26a6f106fe9.1561620219.git.xuanziyang2@huawei.com> To: test-report@dpdk.org Cc: Ziyang Xuan Message-Id: <20190627080737.E152F4C8B@dpdk.org> Date: Thu, 27 Jun 2019 10:07:37 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw55451 [PATCH v6 13/15] net/hinic: add start stop close queue ops X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/55451 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rxq' - possible side-effects? #784: FILE: drivers/net/hinic/hinic_pmd_rx.c:20: +#define HINIC_GET_RQ_LOCAL_CI(rxq) \ + (((rxq)->wq->cons_idx) & HINIC_GET_RQ_WQE_MASK(rxq)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rxq' - possible side-effects? #787: FILE: drivers/net/hinic/hinic_pmd_rx.c:23: +#define HINIC_GET_RQ_LOCAL_PI(rxq) \ + (((rxq)->wq->prod_idx) & HINIC_GET_RQ_WQE_MASK(rxq)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rxq' - possible side-effects? #790: FILE: drivers/net/hinic/hinic_pmd_rx.c:26: +#define HINIC_UPDATE_RQ_LOCAL_CI(rxq, wqebb_cnt) \ + do { \ + (rxq)->wq->cons_idx += (wqebb_cnt); \ + (rxq)->wq->delta += (wqebb_cnt); \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wqebb_cnt' - possible side-effects? #790: FILE: drivers/net/hinic/hinic_pmd_rx.c:26: +#define HINIC_UPDATE_RQ_LOCAL_CI(rxq, wqebb_cnt) \ + do { \ + (rxq)->wq->cons_idx += (wqebb_cnt); \ + (rxq)->wq->delta += (wqebb_cnt); \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rxq' - possible side-effects? #796: FILE: drivers/net/hinic/hinic_pmd_rx.c:32: +#define HINIC_UPDATE_RQ_HW_PI(rxq, pi) \ + (*((rxq)->pi_virt_addr) = \ + cpu_to_be16((pi) & HINIC_GET_RQ_WQE_MASK(rxq))) total: 0 errors, 0 warnings, 5 checks, 1265 lines checked