From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41D4EA046B for ; Thu, 27 Jun 2019 10:09:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CBE2378E; Thu, 27 Jun 2019 10:09:22 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 1684949DF; Thu, 27 Jun 2019 10:09:21 +0200 (CEST) In-Reply-To: References: To: test-report@dpdk.org Cc: Ziyang Xuan Message-Id: <20190627080921.1684949DF@dpdk.org> Date: Thu, 27 Jun 2019 10:09:21 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw55452 [PATCH v6 14/15] net/hinic: add Rx/Tx package burst X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/55452 _coding style issues_ CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #283: FILE: drivers/net/hinic/hinic_pmd_rx.c:735: + volatile __m128i *wqe_be = (volatile __m128i *)src_be32; ^ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects? #729: FILE: drivers/net/hinic/hinic_pmd_tx.c:174: +#define HINIC_GET_SQ_HW_CI(txq) \ + ((be16_to_cpu(*(txq)->cons_idx_addr)) & HINIC_GET_SQ_WQE_MASK(txq)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects? #732: FILE: drivers/net/hinic/hinic_pmd_tx.c:177: +#define HINIC_GET_SQ_LOCAL_CI(txq) \ + (((txq)->wq->cons_idx) & HINIC_GET_SQ_WQE_MASK(txq)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects? #735: FILE: drivers/net/hinic/hinic_pmd_tx.c:180: +#define HINIC_UPDATE_SQ_LOCAL_CI(txq, wqebb_cnt) \ + do { \ + (txq)->wq->cons_idx += wqebb_cnt; \ + (txq)->wq->delta += wqebb_cnt; \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wqebb_cnt' - possible side-effects? #735: FILE: drivers/net/hinic/hinic_pmd_tx.c:180: +#define HINIC_UPDATE_SQ_LOCAL_CI(txq, wqebb_cnt) \ + do { \ + (txq)->wq->cons_idx += wqebb_cnt; \ + (txq)->wq->delta += wqebb_cnt; \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'txq' - possible side-effects? #743: FILE: drivers/net/hinic/hinic_pmd_tx.c:188: +#define HINIC_IS_SQ_EMPTY(txq) (((txq)->wq->delta) == ((txq)->q_depth)) total: 0 errors, 0 warnings, 6 checks, 1614 lines checked