* [dpdk-test-report] |WARNING| pw55641 [PATCH v3 36/42] event/octeontx2: add event timer arm routine
[not found] <20190628182354.228-37-pbhagavatula@marvell.com>
@ 2019-06-28 18:30 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-06-28 18:30 UTC (permalink / raw)
To: test-report; +Cc: pbhagavatula
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/55641
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#120: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:160:
+#define TIM_ARM_FASTPATH_MODES \
+FP(mod_sp, 0, 0, 0, OTX2_TIM_BKT_MOD | OTX2_TIM_ENA_DFB | OTX2_TIM_SP) \
+FP(mod_mp, 0, 0, 1, OTX2_TIM_BKT_MOD | OTX2_TIM_ENA_DFB | OTX2_TIM_MP) \
+FP(mod_fb_sp, 0, 1, 0, OTX2_TIM_BKT_MOD | OTX2_TIM_ENA_FB | OTX2_TIM_SP) \
+FP(mod_fb_mp, 0, 1, 1, OTX2_TIM_BKT_MOD | OTX2_TIM_ENA_FB | OTX2_TIM_MP) \
+FP(and_sp, 1, 0, 0, OTX2_TIM_BKT_AND | OTX2_TIM_ENA_DFB | OTX2_TIM_SP) \
+FP(and_mp, 1, 0, 1, OTX2_TIM_BKT_AND | OTX2_TIM_ENA_DFB | OTX2_TIM_MP) \
+FP(and_fb_sp, 1, 1, 0, OTX2_TIM_BKT_AND | OTX2_TIM_ENA_FB | OTX2_TIM_SP) \
+FP(and_fb_mp, 1, 1, 1, OTX2_TIM_BKT_AND | OTX2_TIM_ENA_FB | OTX2_TIM_MP) \
+
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#130: FILE: drivers/event/octeontx2/otx2_tim_evdev.h:170:
+#define FP(_name, _f3, _f2, _f1, flags) \
+uint16_t otx2_tim_arm_burst_ ## _name( \
+ const struct rte_event_timer_adapter *adptr, \
+ struct rte_event_timer **tim, \
+ const uint16_t nb_timers);
total: 1 errors, 1 warnings, 385 lines checked
^ permalink raw reply [flat|nested] only message in thread