From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA87AA0487 for ; Tue, 2 Jul 2019 12:14:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6FAC1B9A8; Tue, 2 Jul 2019 12:14:24 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 26E061B9B7; Tue, 2 Jul 2019 12:14:24 +0200 (CEST) In-Reply-To: <20190702101355.26300-1-jgrajcia@cisco.com> References: <20190702101355.26300-1-jgrajcia@cisco.com> To: test-report@dpdk.org Cc: Jakub Grajciar Message-Id: <20190702101424.26E061B9B7@dpdk.org> Date: Tue, 2 Jul 2019 12:14:24 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw55862 [PATCH] net/memif: zero-copy slave X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/55862 _coding style issues_ WARNING:LONG_LINE: line over 90 characters #163: FILE: drivers/net/memif/memif_rxtx.c:67: + struct pmd_process_private *proc_private = rte_eth_devices[mq->in_port].process_private; WARNING:LONG_LINE: line over 90 characters #242: FILE: drivers/net/memif/memif_rxtx.c:146: + (uint8_t *)memif_get_buffer(proc_private, d0) + src_off, cp_len); WARNING:LONG_LINE: line over 90 characters #292: FILE: drivers/net/memif/memif_rxtx.c:196: + struct pmd_process_private *proc_private = rte_eth_devices[mq->in_port].process_private; WARNING:INDENTED_LABEL: labels should not be indented #333: FILE: drivers/net/memif/memif_rxtx.c:237: + next_slot: WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon #366: FILE: drivers/net/memif/memif_rxtx.c:270: +refill:;; WARNING:LONG_LINE: line over 90 characters #405: FILE: drivers/net/memif/memif_rxtx.c:309: + struct pmd_process_private *proc_private = rte_eth_devices[mq->in_port].process_private; WARNING:LONG_LINE: line over 90 characters #560: FILE: drivers/net/memif/memif_rxtx.c:464: + struct pmd_process_private *proc_private = rte_eth_devices[mq->in_port].process_private; WARNING:LONG_LINE: line over 90 characters #594: FILE: drivers/net/memif/memif_rxtx.c:498: + used_slots = memif_tx_one_zc(proc_private, mq, ring, *bufs++, mask, slot, n_free); WARNING:LONG_LINE: line over 90 characters #601: FILE: drivers/net/memif/memif_rxtx.c:505: + used_slots = memif_tx_one_zc(proc_private, mq, ring, *bufs++, mask, slot, n_free); WARNING:LONG_LINE: line over 90 characters #608: FILE: drivers/net/memif/memif_rxtx.c:512: + used_slots = memif_tx_one_zc(proc_private, mq, ring, *bufs++, mask, slot, n_free); WARNING:LONG_LINE: line over 90 characters #615: FILE: drivers/net/memif/memif_rxtx.c:519: + used_slots = memif_tx_one_zc(proc_private, mq, ring, *bufs++, mask, slot, n_free); WARNING:LONG_LINE: line over 90 characters #622: FILE: drivers/net/memif/memif_rxtx.c:526: + used_slots = memif_tx_one_zc(proc_private, mq, ring, *bufs++, mask, slot, n_free); WARNING:LONG_LINE: line over 90 characters #951: FILE: drivers/net/memif/rte_eth_memif.c:65: +memif_region_init_zc(const struct rte_memseg_list *msl, const struct rte_memseg *ms, void *arg) CHECK:BRACES: braces {} should be used on all arms of this statement #966: FILE: drivers/net/memif/rte_eth_memif.c:80: + if (r == NULL) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #981: FILE: drivers/net/memif/rte_eth_memif.c:95: + } else CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i > 0' #1398: FILE: drivers/net/memif/rte_eth_memif.c:359: + if ((i > 0) && (pmd->flags & ETH_MEMIF_FLAG_ZERO_COPY)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i > 0' #1603: FILE: drivers/net/memif/rte_eth_memif.c:558: + if ((i > 0) && (pmd->flags & ETH_MEMIF_FLAG_ZERO_COPY)) { WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1721: FILE: drivers/net/memif/rte_eth_memif.h:68: + /**< Stored mbufs. Used in zero-copy tx. Slave stores transmitted + mbufs to free them once master has received them. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #1721: FILE: drivers/net/memif/rte_eth_memif.h:68: + mbufs to free them once master has received them. */ total: 0 errors, 15 warnings, 4 checks, 1628 lines checked