From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Xiao Zhang <xiao.zhang@intel.com>
Subject: [dpdk-test-report] |WARNING| pw56060 [DPDK] net/e1000: Intel i219 reset hang issue fix.
Date: Thu, 4 Jul 2019 04:29:06 +0200 (CEST) [thread overview]
Message-ID: <20190704022906.A83DC4C93@dpdk.org> (raw)
In-Reply-To: <1562239487-34431-1-git-send-email-xiao.zhang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56060
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16:
Unit hang may occur if multiple descriptors are available in the rings during
ERROR:GERRIT_CHANGE_ID: Remove Gerrit Change-Id's before submitting upstream.
#19:
Change-Id: Ia5e8dd06ad890d19f5093f1696faf68f7f52b491
WARNING:BRACES: braces {} are not necessary for single statement blocks
#60: FILE: drivers/net/e1000/igb_ethdev.c:1593:
+ if (hw->mac.type >= e1000_pch_spt) {
+ igb_flush_desc_rings(dev);
+ }
ERROR:SPACING: space required before the open parenthesis '('
#91: FILE: drivers/net/e1000/igb_rxtx.c:2981:
+ if(tdt != txq->tx_tail)
ERROR:SPACING: spaces required around that '==' (ctx:VxW)
#100: FILE: drivers/net/e1000/igb_rxtx.c:2990:
+ if (txq->tx_tail== txq->nb_tx_desc)
^
ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#101: FILE: drivers/net/e1000/igb_rxtx.c:2991:
+ txq->tx_tail= 0;
^
WARNING:BRACES: braces {} are not necessary for single statement blocks
#159: FILE: drivers/net/e1000/igb_rxtx.c:3049:
+ if (fextnvm7 & E1000_FEXTNVM7_NEED_DESCRING_FLUSH) {
+ e1000_flush_rx_ring(dev);
+ }
total: 4 errors, 3 warnings, 0 checks, 116 lines checked
parent reply other threads:[~2019-07-04 2:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1562239487-34431-1-git-send-email-xiao.zhang@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704022906.A83DC4C93@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=xiao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).