From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andy Pei <andy.pei@intel.com>
Subject: [dpdk-test-report] |WARNING| pw56199 [PATCH v4] net/i40e: i40e get link status update from ipn3ke
Date: Mon, 8 Jul 2019 05:10:40 +0200 (CEST) [thread overview]
Message-ID: <20190708031040.79F3B4C90@dpdk.org> (raw)
In-Reply-To: <1562554988-17394-1-git-send-email-andy.pei@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56199
_coding style issues_
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#89: FILE: drivers/net/i40e/i40e_ethdev.c:636:
+ if (RTE_ETH_NAME_MAX_LEN > strlen(value)) {
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#92: FILE: drivers/net/i40e/i40e_ethdev.c:639:
+ return 0;
+ } else {
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#174: FILE: drivers/net/i40e/i40e_ethdev.c:721:
+ i40e_eth_dev_get_by_switch_mode_name(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#193: FILE: drivers/net/i40e/i40e_ethdev.c:740:
+ switch_ethdev = i40e_get_switch_ethdev_from_devargs(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#254: FILE: drivers/net/i40e/i40e_ethdev.c:2931:
+ i40e_get_switch_ethdev_from_devargs(
total: 0 errors, 2 warnings, 208 lines checked
parent reply other threads:[~2019-07-08 3:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1562554988-17394-1-git-send-email-andy.pei@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708031040.79F3B4C90@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=andy.pei@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).