From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E83C1A00E6 for ; Mon, 8 Jul 2019 12:55:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E057E325F; Mon, 8 Jul 2019 12:55:21 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 8240B5905; Mon, 8 Jul 2019 12:55:21 +0200 (CEST) In-Reply-To: <20190708183959.50293-3-jin.yu@intel.com> References: <20190708183959.50293-3-jin.yu@intel.com> To: test-report@dpdk.org Cc: JinYu Message-Id: <20190708105521.8240B5905@dpdk.org> Date: Mon, 8 Jul 2019 12:55:21 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw56227 [PATCH 2/2] [2/2]vhost: Add vhost-user-blk example which support inflight X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/56227 _coding style issues_ ERROR:TRAILING_WHITESPACE: trailing whitespace #192: FILE: examples/vhost_blk/blk.c:72: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #201: FILE: examples/vhost_blk/blk.c:81: +^I^I^Ifprintf(stderr, "%s - passed IO buffer is not multiple of 512b (req_idx = %"PRIu16"). ", $ WARNING:LONG_LINE: line over 90 characters #201: FILE: examples/vhost_blk/blk.c:81: + fprintf(stderr, "%s - passed IO buffer is not multiple of 512b (req_idx = %"PRIu16"). ", ERROR:TRAILING_WHITESPACE: trailing whitespace #212: FILE: examples/vhost_blk/blk.c:92: +^I^I^Ifprintf(stderr, "%s - passed IO buffer is not multiple of 512b (req_idx = %"PRIu16"). ", $ WARNING:LONG_LINE: line over 90 characters #212: FILE: examples/vhost_blk/blk.c:92: + fprintf(stderr, "%s - passed IO buffer is not multiple of 512b (req_idx = %"PRIu16"). ", ERROR:TRAILING_WHITESPACE: trailing whitespace #216: FILE: examples/vhost_blk/blk.c:96: +^I^I$ WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon #225: FILE: examples/vhost_blk/blk.c:105: + return VIRTIO_BLK_S_UNSUPP;; WARNING:LONG_LINE: line over 90 characters #228: FILE: examples/vhost_blk/blk.c:108: + vhost_strcpy_pad(task->iovs[0].iov_base, bdev->product_name, used_len, ' '); WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return #232: FILE: examples/vhost_blk/blk.c:112: + return VIRTIO_BLK_S_UNSUPP; + break; ERROR:SPACING: space prohibited before that close parenthesis ')' #394: FILE: examples/vhost_blk/vhost_blk.c:25: + (1ULL << VIRTIO_F_VERSION_1) ) ERROR:TRAILING_WHITESPACE: trailing whitespace #395: FILE: examples/vhost_blk/vhost_blk.c:26: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #458: FILE: examples/vhost_blk/vhost_blk.c:89: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #469: FILE: examples/vhost_blk/vhost_blk.c:100: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #549: FILE: examples/vhost_blk/vhost_blk.c:180: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #560: FILE: examples/vhost_blk/vhost_blk.c:191: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #566: FILE: examples/vhost_blk/vhost_blk.c:197: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #572: FILE: examples/vhost_blk/vhost_blk.c:203: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #575: FILE: examples/vhost_blk/vhost_blk.c:206: +^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #602: FILE: examples/vhost_blk/vhost_blk.c:233: +^I^I} $ ERROR:TRAILING_WHITESPACE: trailing whitespace #603: FILE: examples/vhost_blk/vhost_blk.c:234: +^I^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #614: FILE: examples/vhost_blk/vhost_blk.c:245: +^I}^I^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #677: FILE: examples/vhost_blk/vhost_blk.c:308: +^I^I} $ ERROR:TRAILING_WHITESPACE: trailing whitespace #678: FILE: examples/vhost_blk/vhost_blk.c:309: +^I^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #687: FILE: examples/vhost_blk/vhost_blk.c:318: +^I^I$ WARNING:BRACES: braces {} are not necessary for single statement blocks #722: FILE: examples/vhost_blk/vhost_blk.c:353: + if (resubmit_inflight && resubmit_inflight->resubmit_num) { + submit_inflight_vq(ctrlr, i); + } ERROR:SPACING: space required before the open parenthesis '(' #728: FILE: examples/vhost_blk/vhost_blk.c:359: + for(i = 0; i < NUM_OF_BLK_QUEUES; i++) { WARNING:BRACES: braces {} are not necessary for single statement blocks #728: FILE: examples/vhost_blk/vhost_blk.c:359: + for(i = 0; i < NUM_OF_BLK_QUEUES; i++) { + process_requestq(ctrlr, i); + } WARNING:BRACES: braces {} are not necessary for single statement blocks #761: FILE: examples/vhost_blk/vhost_blk.c:392: + if (ret) { + fprintf(stderr, "Get Controller memory region failed "); + } ERROR:TRAILING_WHITESPACE: trailing whitespace #773: FILE: examples/vhost_blk/vhost_blk.c:404: +^I^Iret = rte_vhost_get_vring_base(ctrlr->bdev->vid, i, &blk_vq->last_avail_idx, $ WARNING:LONG_LINE: line over 90 characters #773: FILE: examples/vhost_blk/vhost_blk.c:404: + ret = rte_vhost_get_vring_base(ctrlr->bdev->vid, i, &blk_vq->last_avail_idx, WARNING:LONG_LINE: line over 90 characters #778: FILE: examples/vhost_blk/vhost_blk.c:409: + ret = rte_vhost_get_vhost_ring_inflight_split(ctrlr->bdev->vid, i, inflight_vq); WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon #818: FILE: examples/vhost_blk/vhost_blk.c:449: + return;; ERROR:TRAILING_WHITESPACE: trailing whitespace #819: FILE: examples/vhost_blk/vhost_blk.c:450: +^I$ ERROR:SPACING: space required after that ';' (ctx:VxV) #822: FILE: examples/vhost_blk/vhost_blk.c:453: + for (i = 0; i < NUM_OF_BLK_QUEUES;i++) { ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #990: FILE: examples/vhost_blk/vhost_blk.h:25: +#define min(a,b) (((a)<(b))?(a):(b)) ^ ERROR:SPACING: spaces required around that '<' (ctx:VxV) #990: FILE: examples/vhost_blk/vhost_blk.h:25: +#define min(a,b) (((a)<(b))?(a):(b)) ^ ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #1059: FILE: examples/vhost_blk/vhost_blk.h:94: +struct vhost_blk_ctrlr* vhost_blk_ctrlr_find(__rte_unused const char *ctrlr_name); ERROR:TRAILING_WHITESPACE: trailing whitespace #1086: FILE: examples/vhost_blk/vhost_blk_compat.c:20: +#define VHOST_USER_GET_CONFIG 24^I$ WARNING:BRACES: braces {} are not necessary for single statement blocks #1154: FILE: examples/vhost_blk/vhost_blk_compat.c:88: + if (!g_should_stop && ctrlr->started) { + vhost_blk_device_ops.destroy_device(vid); + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1162: FILE: examples/vhost_blk/vhost_blk_compat.c:96: + if (!g_should_stop && ctrlr->started) { + vhost_blk_device_ops.destroy_device(vid); + } ERROR:TRAILING_WHITESPACE: trailing whitespace #1176: FILE: examples/vhost_blk/vhost_blk_compat.c:110: +^I^Irc = vhost_blk_get_config(ctrlr->bdev, $ WARNING:BRACES: braces {} are not necessary for single statement blocks #1178: FILE: examples/vhost_blk/vhost_blk_compat.c:112: + if (rc != 0) { + msg->size = 0; + } ERROR:TRAILING_WHITESPACE: trailing whitespace #1184: FILE: examples/vhost_blk/vhost_blk_compat.c:118: +^Icase VHOST_USER_SET_CONFIG: $ WARNING:BRACES: braces {} are not necessary for single statement blocks #1224: FILE: examples/vhost_blk/vhost_blk_compat.c:158: + if (g_should_stop && !ctrlr->started) { + vhost_blk_device_ops.new_device(vid); + } ERROR:TRAILING_WHITESPACE: trailing whitespace #1239: FILE: examples/vhost_blk/vhost_blk_compat.c:173: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1239: FILE: examples/vhost_blk/vhost_blk_compat.c:173: + $ WARNING:BRACES: braces {} are not necessary for single statement blocks #1246: FILE: examples/vhost_blk/vhost_blk_compat.c:180: + if (rc != 0) { + fprintf(stderr, "rte_vhost_extern_callback_register() failed for vid = %d ", vid); + } WARNING:LONG_LINE: line over 90 characters #1247: FILE: examples/vhost_blk/vhost_blk_compat.c:181: + fprintf(stderr, "rte_vhost_extern_callback_register() failed for vid = %d ", vid); total: 30 errors, 18 warnings, 1179 lines checked