From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Subject: [dpdk-test-report] |WARNING| pw56332 [PATCH v3 07/11] net/softnic: add config flexibility to softnic tm
Date: Thu, 11 Jul 2019 12:27:30 +0200 (CEST) [thread overview]
Message-ID: <20190711102730.BE6161BDFB@dpdk.org> (raw)
In-Reply-To: <20190711102659.59001-8-jasvinder.singh@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56332
_coding style issues_
CHECK:SPACING: No space is necessary after a cast
#220: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:620:
+ (uint32_t *) calloc(RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE,
WARNING:LONG_LINE: line over 90 characters
#366: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:833:
+ for (q = 0; q < RTE_SCHED_BE_QUEUES_PER_PIPE; q++) {
WARNING:LONG_LINE: line over 90 characters
#368: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:835:
+ queue_node_id(n_spp, n_pps, s, p, t, q),
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#375: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:842:
+ if (status)
WARNING:LONG_LINE: line over 90 characters
#559: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1139:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[0], tokens[43]) != 0) {
WARNING:LONG_LINE: line over 90 characters
#578: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1155:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[1], tokens[45]) != 0) {
WARNING:LONG_LINE: line over 90 characters
#597: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1171:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[2], tokens[47]) != 0) {
WARNING:LONG_LINE: line over 90 characters
#616: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1187:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[3], tokens[49]) != 0) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#629: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1200:
+ if (strcmp(tokens[51], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#631: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1202:
+ else {
WARNING:LONG_LINE: line over 90 characters
#632: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1203:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[4], tokens[51]) != 0) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#645: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1216:
+ if (strcmp(tokens[53], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#647: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1218:
+ else {
WARNING:LONG_LINE: line over 90 characters
#648: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1219:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[5], tokens[53]) != 0) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#661: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1232:
+ if (strcmp(tokens[55], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#663: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1234:
+ else {
WARNING:LONG_LINE: line over 90 characters
#664: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1235:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[6], tokens[55]) != 0) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#677: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1248:
+ if (strcmp(tokens[57], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#679: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1250:
+ else {
WARNING:LONG_LINE: line over 90 characters
#680: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1251:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[7], tokens[57]) != 0) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#693: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1264:
+ if (strcmp(tokens[59], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#695: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1266:
+ else {
WARNING:LONG_LINE: line over 90 characters
#696: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1267:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[8], tokens[59]) != 0) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#709: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1280:
+ if (strcmp(tokens[61], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#711: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1282:
+ else {
WARNING:LONG_LINE: line over 90 characters
#712: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1283:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[9], tokens[61]) != 0) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#725: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1296:
+ if (strcmp(tokens[63], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#727: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1298:
+ else {
WARNING:LONG_LINE: line over 90 characters
#728: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1299:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[10], tokens[63]) != 0) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#741: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1312:
+ if (strcmp(tokens[65], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#743: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1314:
+ else {
WARNING:LONG_LINE: line over 90 characters
#744: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1315:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[11], tokens[65]) != 0) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#757: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1328:
+ if (strcmp(tokens[67], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#759: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1330:
+ else {
WARNING:LONG_LINE: line over 90 characters
#760: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1331:
+ if (softnic_parser_read_uint32(&p.shared_shaper_id.tc[12], tokens[67]) != 0) {
WARNING:LONG_LINE: line over 90 characters
#790: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1355:
+ if (softnic_parser_read_uint32(&p.weight.queue[i], tokens[70 + j]) != 0) {
WARNING:LONG_LINE: line over 90 characters
#839: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:371:
+ (n_queues_max * RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE) / RTE_SCHED_QUEUES_PER_PIPE;
total: 0 errors, 18 warnings, 19 checks, 929 lines checked
parent reply other threads:[~2019-07-11 10:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190711102659.59001-8-jasvinder.singh@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711102730.BE6161BDFB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).