From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A5405A00E6
	for <public@inbox.dpdk.org>; Thu, 11 Jul 2019 12:27:39 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D36871B942;
	Thu, 11 Jul 2019 12:27:38 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id EC3231B9A7; Thu, 11 Jul 2019 12:27:34 +0200 (CEST)
In-Reply-To: <20190711102659.59001-11-jasvinder.singh@intel.com>
References: <20190711102659.59001-11-jasvinder.singh@intel.com>
To: test-report@dpdk.org
Cc: Jasvinder Singh <jasvinder.singh@intel.com>
Message-Id: <20190711102734.EC3231B9A7@dpdk.org>
Date: Thu, 11 Jul 2019 12:27:34 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw56335 [PATCH v3 10/11]
	examples/qos_sched: add tc and queue config flexibility
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56335

_coding style issues_


WARNING:LONG_LINE_COMMENT: line over 90 characters
#62: FILE: examples/qos_sched/app_thread.c:43:
+			(RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE - 1) : *queue); /* Destination IP */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#606: FILE: examples/qos_sched/stats.c:25:
+	if (i == nb_pfc || subport_id >= port_params.n_subports_per_port ||
[...]
+			return -1;

WARNING:LONG_LINE: line over 90 characters
#698: FILE: examples/qos_sched/stats.c:92:
+				rte_sched_queue_read_stats(port, queue_id + i, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#847: FILE: examples/qos_sched/stats.c:175:
+		subport_queue_id += port_params.n_pipes_per_subport * RTE_SCHED_QUEUES_PER_PIPE;

WARNING:LONG_LINE: line over 90 characters
#855: FILE: examples/qos_sched/stats.c:183:
+				queue_id = subport_queue_id + i * RTE_SCHED_QUEUES_PER_PIPE + tc;

WARNING:LONG_LINE: line over 90 characters
#861: FILE: examples/qos_sched/stats.c:189:
+							i * RTE_SCHED_QUEUES_PER_PIPE + tc + j;

WARNING:LONG_LINE: line over 90 characters
#862: FILE: examples/qos_sched/stats.c:190:
+					rte_sched_queue_read_stats(port, queue_id, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#871: FILE: examples/qos_sched/stats.c:199:
+			average += part_average / (port_params.n_pipes_per_subport) * RTE_SCHED_BE_QUEUES_PER_PIPE;

WARNING:LONG_LINE: line over 90 characters
#916: FILE: examples/qos_sched/stats.c:232:
+		subport_queue_id += port_params.n_pipes_per_subport * RTE_SCHED_QUEUES_PER_PIPE;

WARNING:LONG_LINE: line over 90 characters
#936: FILE: examples/qos_sched/stats.c:242:
+				rte_sched_queue_read_stats(port, queue_id + j, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#944: FILE: examples/qos_sched/stats.c:247:
+		average += part_average / (port_params.n_pipes_per_subport * RTE_SCHED_QUEUES_PER_PIPE);

WARNING:LONG_LINE: line over 90 characters
#1010: FILE: examples/qos_sched/stats.c:285:
+		printf("|  %d | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " |
", i,

WARNING:LONG_LINE: line over 90 characters
#1091: FILE: examples/qos_sched/stats.c:328:
+			printf("|  %d |   %d   | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11i |
", i, 0,

WARNING:LONG_LINE: line over 90 characters
#1092: FILE: examples/qos_sched/stats.c:329:
+				stats.n_pkts, stats.n_pkts_dropped, stats.n_bytes, stats.n_bytes_dropped, qlen);

WARNING:LONG_LINE: line over 90 characters
#1096: FILE: examples/qos_sched/stats.c:333:
+				rte_sched_queue_read_stats(port, queue_id + i + j, &stats, &qlen);

WARNING:LONG_LINE: line over 90 characters
#1097: FILE: examples/qos_sched/stats.c:334:
+				printf("|  %d |   %d   | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11" PRIu32 " | %11i |
", i, j,

WARNING:LONG_LINE: line over 90 characters
#1098: FILE: examples/qos_sched/stats.c:335:
+					stats.n_pkts, stats.n_pkts_dropped, stats.n_bytes, stats.n_bytes_dropped, qlen);

total: 0 errors, 17 warnings, 1021 lines checked