* [dpdk-test-report] |WARNING| pw56642 [PATCH v5 07/11] net/softnic: add config flexibility to softnic tm
[not found] <20190717144245.138876-8-jasvinder.singh@intel.com>
@ 2019-07-17 14:43 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-07-17 14:43 UTC (permalink / raw)
To: test-report; +Cc: Jasvinder Singh
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56642
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#334: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:834:
+ for (q = 0; q < RTE_SCHED_BE_QUEUES_PER_PIPE; q++) {
WARNING:LONG_LINE: line over 90 characters
#336: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:836:
+ queue_node_id(n_spp, n_pps, s, p, t, q),
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#343: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:843:
+ if (status)
CHECK:BRACES: braces {} should be used on all arms of this statement
#601: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1205:
+ if (strcmp(tokens[51], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#603: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1207:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#618: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1222:
+ if (strcmp(tokens[53], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#620: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1224:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#635: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1239:
+ if (strcmp(tokens[55], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#637: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1241:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#652: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1256:
+ if (strcmp(tokens[57], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#654: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1258:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#669: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1273:
+ if (strcmp(tokens[59], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#671: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1275:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#686: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1290:
+ if (strcmp(tokens[61], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#688: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1292:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#703: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1307:
+ if (strcmp(tokens[63], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#705: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1309:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#720: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1324:
+ if (strcmp(tokens[65], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#722: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1326:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#737: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1341:
+ if (strcmp(tokens[67], "none") == 0)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#739: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1343:
+ else {
WARNING:LONG_LINE: line over 90 characters
#812: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:371:
+ (n_queues_max * RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE) / RTE_SCHED_QUEUES_PER_PIPE;
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#993: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:3045:
+^Ireturn ^Iport_queue_id;$
WARNING:LONG_LINE: line over 90 characters
#1080: FILE: drivers/net/softnic/rte_eth_softnic_tm.c:3271:
+ nt->stats.leaf.n_pkts_dropped[RTE_COLOR_GREEN] += s.n_pkts_dropped;
total: 0 errors, 6 warnings, 18 checks, 1002 lines checked
^ permalink raw reply [flat|nested] only message in thread