From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Phil Yang <phil.yang@arm.com>
Subject: [dpdk-test-report] |WARNING| pw56946 [PATCH v7 1/3] eal/arm64: add 128-bit atomic compare exchange
Date: Tue, 23 Jul 2019 07:59:20 +0200 (CEST) [thread overview]
Message-ID: <20190723055920.DA6431BF86@dpdk.org> (raw)
In-Reply-To: <1563861443-14491-1-git-send-email-phil.yang@arm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/56946
_coding style issues_
WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#162: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:65:
+ */ \
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#185: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:88:
+#define __ATOMIC128_LDX_OP(ldx_op_name, op_string) \
+static inline rte_int128_t \
+ldx_op_name(const rte_int128_t *src) \
+{ \
+ rte_int128_t ret; \
+ asm volatile( \
+ op_string " %0, %1, %2" \
+ : "=&r" (ret.val[0]), \
+ "=&r" (ret.val[1]) \
+ : "Q" (src->val[0]) \
+ : "memory"); \
+ return ret; \
+}
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#202: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:105:
+#define __ATOMIC128_STX_OP(stx_op_name, op_string) \
+static inline uint32_t \
+stx_op_name(rte_int128_t *dst, const rte_int128_t src) \
+{ \
+ uint32_t ret; \
+ asm volatile( \
+ op_string " %w0, %1, %2, %3" \
+ : "=&r" (ret) \
+ : "r" (src.val[0]), \
+ "r" (src.val[1]), \
+ "Q" (dst->val[0]) \
+ : "memory"); \
+ /* Return 0 on success, 1 on failure */ \
+ return ret; \
+}
total: 0 errors, 3 warnings, 259 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
parent reply other threads:[~2019-07-23 5:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1563861443-14491-1-git-send-email-phil.yang@arm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723055920.DA6431BF86@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=phil.yang@arm.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).