automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: JinYu <jin.yu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw57102 [PATCH v4 2/2] vhost: Add vhost-user-blk example which support inflight
Date: Thu, 25 Jul 2019 15:38:41 +0200 (CEST)	[thread overview]
Message-ID: <20190725133841.901C71C359@dpdk.org> (raw)
In-Reply-To: <20190725212335.9675-3-jin.yu@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57102

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#471: FILE: examples/vhost_blk/vhost_blk.c:94:
+	if (cur_desc->flags & VIRTQ_DESC_F_NEXT) {
+		return &inflight_packed->desc[cur_desc->next];
+	}

ERROR:SPACING: space prohibited after that open parenthesis '('
#552: FILE: examples/vhost_blk/vhost_blk.c:175:
+		desc->flags = desc->flags & ~( VIRTQ_DESC_F_AVAIL |

WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#585: FILE: examples/vhost_blk/vhost_blk.c:208:
+	vq = task->vq;;

ERROR:SPACING: space prohibited after that open parenthesis '('
#600: FILE: examples/vhost_blk/vhost_blk.c:223:
+		desc->flags = desc->flags & ~( VIRTQ_DESC_F_AVAIL |

ERROR:TRAILING_WHITESPACE: trailing whitespace
#742: FILE: examples/vhost_blk/vhost_blk.c:365:
+^I^Irte_vhost_set_inflight_desc_packed(ctrlr->bdev->vid, q_idx, $

WARNING:LONG_LINE: line over 90 characters
#810: FILE: examples/vhost_blk/vhost_blk.c:433:
+		task->blk_task.req = (void *)(uintptr_t)gpa_to_vva(task->blk_task.bdev->vid,

ERROR:TRAILING_WHITESPACE: trailing whitespace
#849: FILE: examples/vhost_blk/vhost_blk.c:472:
+^I^Iinflight_submit_completion_packed(task, q_idx, &used_idx, $

WARNING:LONG_LINE: line over 90 characters
#1069: FILE: examples/vhost_blk/vhost_blk.c:692:
+		task->desc_split = descriptor_get_next_split(task->vq->desc, task->desc_split);

WARNING:TABSTOP: Statements should start on a tabstop
#1135: FILE: examples/vhost_blk/vhost_blk.c:758:
+		    }

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1140: FILE: examples/vhost_blk/vhost_blk.c:763:
+^I^I^Iif (ctrlr->packed) $

WARNING:LONG_LINE: line over 90 characters
#1210: FILE: examples/vhost_blk/vhost_blk.c:833:
+			rte_vhost_get_vring_base_counter_from_inflight(ctrlr->bdev->vid, i,

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'JinYu <jin.yu@intel.com>'

total: 5 errors, 7 warnings, 1665 lines checked

           reply	other threads:[~2019-07-25 13:38 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190725212335.9675-3-jin.yu@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190725133841.901C71C359@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jin.yu@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).