From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CA146A10DA
	for <public@inbox.dpdk.org>; Wed, 31 Jul 2019 14:58:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C32181C198;
	Wed, 31 Jul 2019 14:58:16 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 2B98B1C1A4; Wed, 31 Jul 2019 14:58:16 +0200 (CEST)
In-Reply-To: <20190731204050.40633-3-jin.yu@intel.com>
References: <20190731204050.40633-3-jin.yu@intel.com>
To: test-report@dpdk.org
Cc: JinYu <jin.yu@intel.com>
Message-Id: <20190731125816.2B98B1C1A4@dpdk.org>
Date: Wed, 31 Jul 2019 14:58:16 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw57323 [PATCH v4 2/2] vhost: Add
	vhost-user-blk example which support inflight
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57323

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#473: FILE: examples/vhost_blk/vhost_blk.c:96:
+	if (!!(cur_desc->flags & VIRTQ_DESC_F_NEXT)) {
+		return &inflight_packed->desc[cur_desc->next];
+	}

WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#820: FILE: examples/vhost_blk/vhost_blk.c:443:
+		chunck_len = task->inflight_desc->len;;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#901: FILE: examples/vhost_blk/vhost_blk.c:524:
+^Iwhile (j++ < 1000000 && $

WARNING:LONG_LINE: line over 90 characters
#923: FILE: examples/vhost_blk/vhost_blk.c:546:
+		task[i]->desc_packed = descriptor_get_next_packed(task[i]->vq, &avail_idx);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#955: FILE: examples/vhost_blk/vhost_blk.c:578:
+		if (g_should_stop == 1) {
+			goto free_task;
+		}

WARNING:LONG_LINE: line over 90 characters
#1253: FILE: examples/vhost_blk/vhost_blk.c:876:
+	while (j++ < 1000000 && vq->avail->idx != blk_vq->last_avail_idx && i < MAX_TASK) {

WARNING:LONG_LINE: line over 90 characters
#1263: FILE: examples/vhost_blk/vhost_blk.c:886:
+		rte_vhost_set_inflight_desc_split(ctrlr->bdev->vid, q_idx, task[i]->req_idx);

ERROR:SPACING: space required before the open parenthesis '('
#1476: FILE: examples/vhost_blk/vhost_blk.c:1099:
+	while(g_should_stop != 2);

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1476: FILE: examples/vhost_blk/vhost_blk.c:1099:
+	while(g_should_stop != 2);

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'JinYu <jin.yu@intel.com>'

total: 3 errors, 7 warnings, 1883 lines checked