From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 780B3A0471
	for <public@inbox.dpdk.org>; Wed, 14 Aug 2019 10:30:37 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 6DF5A378B;
	Wed, 14 Aug 2019 10:30:37 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 053C737B7; Wed, 14 Aug 2019 10:30:36 +0200 (CEST)
In-Reply-To: <1565771263-27353-1-git-send-email-phil.yang@arm.com>
References: <1565771263-27353-1-git-send-email-phil.yang@arm.com>
To: test-report@dpdk.org
Cc: Phil Yang <phil.yang@arm.com>
Message-Id: <20190814083036.053C737B7@dpdk.org>
Date: Wed, 14 Aug 2019 10:30:36 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw57675 [PATCH v9 1/3] eal/arm64: add
	128-bit atomic compare exchange
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57675

_coding style issues_


WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#173: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:65:
+	 */                                                                 \

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#196: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:88:
+#define __ATOMIC128_LDX_OP(ldx_op_name, op_string)                          \
+static inline rte_int128_t                                                  \
+ldx_op_name(const rte_int128_t *src)                                        \
+{                                                                           \
+	rte_int128_t ret;                                                   \
+	asm volatile(                                                       \
+			op_string " %0, %1, %2"                             \
+			: "=&r" (ret.val[0]),                               \
+			  "=&r" (ret.val[1])                                \
+			: "Q" (src->val[0])                                 \
+			: "memory");                                        \
+	return ret;                                                         \
+}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#213: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:105:
+#define __ATOMIC128_STX_OP(stx_op_name, op_string)                          \
+static inline uint32_t                                                      \
+stx_op_name(rte_int128_t *dst, const rte_int128_t src)                      \
+{                                                                           \
+	uint32_t ret;                                                       \
+	asm volatile(                                                       \
+			op_string " %w0, %1, %2, %3"                        \
+			: "=&r" (ret)                                       \
+			: "r" (src.val[0]),                                 \
+			  "r" (src.val[1]),                                 \
+			  "Q" (dst->val[0])                                 \
+			: "memory");                                        \
+	/* Return 0 on success, 1 on failure */                             \
+	return ret;                                                         \
+}

total: 0 errors, 3 warnings, 260 lines checked
__rte_experimental must appear alone on the line immediately preceding the return type of a function.