automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw57855 [PATCH 11/22] net/hns3: add support for flow control of hns3 PMD driver
Date: Fri, 23 Aug 2019 15:51:23 +0200 (CEST)	[thread overview]
Message-ID: <20190823135123.2C77A1C00D@dpdk.org> (raw)
In-Reply-To: <1566568031-45991-12-git-send-email-xavier.huwei@huawei.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57855

_coding style issues_


CHECK:BRACES: braces {} should be used on all arms of this statement
#1066: FILE: drivers/net/hns3/hns3_dcb.c:1024:
+	if (pause_time > PAUSE_TIME_DIV_BY * HNS3_DEFAULT_PAUSE_TRANS_GAP)
[...]
+	else if (pause_time >= PAUSE_TIME_MIN_VALUE &&
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#1071: FILE: drivers/net/hns3/hns3_dcb.c:1029:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#1159: FILE: drivers/net/hns3/hns3_dcb.c:1117:
+	if (hw->current_fc_status == HNS3_FC_STATUS_MAC_PAUSE)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#1161: FILE: drivers/net/hns3/hns3_dcb.c:1119:
+	else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#1174: FILE: drivers/net/hns3/hns3_dcb.c:1132:
+	if (hw->current_fc_status == HNS3_FC_STATUS_PFC)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#1176: FILE: drivers/net/hns3/hns3_dcb.c:1134:
+	else {

total: 0 errors, 0 warnings, 6 checks, 2050 lines checked

           reply	other threads:[~2019-08-23 13:51 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1566568031-45991-12-git-send-email-xavier.huwei@huawei.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823135123.2C77A1C00D@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=xavier.huwei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).