automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Qi Zhang <qi.z.zhang@intel.com>
Subject: [dpdk-test-report] |WARNING| pw57942 [PATCH 41/63] net/ice/base: move and add some help function and macros
Date: Mon, 26 Aug 2019 12:55:17 +0200 (CEST)	[thread overview]
Message-ID: <20190826105517.484AC1D176@dpdk.org> (raw)
In-Reply-To: <20190826105105.19121-42-qi.z.zhang@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57942

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#98: FILE: drivers/net/ice/base/ice_type.h:33:
+#define ROUND_UP(a, b)	((b) * DIVIDE_AND_ROUND_UP((a), (b)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr1' - possible side-effects?
#138: FILE: drivers/net/ice/base/ice_type.h:141:
+#define IS_ETHER_ADDR_EQUAL(addr1, addr2) \
+	(((bool)((((u16 *)(addr1))[0] == ((u16 *)(addr2))[0]))) && \
+	 ((bool)((((u16 *)(addr1))[1] == ((u16 *)(addr2))[1]))) && \
+	 ((bool)((((u16 *)(addr1))[2] == ((u16 *)(addr2))[2]))))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr2' - possible side-effects?
#138: FILE: drivers/net/ice/base/ice_type.h:141:
+#define IS_ETHER_ADDR_EQUAL(addr1, addr2) \
+	(((bool)((((u16 *)(addr1))[0] == ((u16 *)(addr2))[0]))) && \
+	 ((bool)((((u16 *)(addr1))[1] == ((u16 *)(addr2))[1]))) && \
+	 ((bool)((((u16 *)(addr1))[2] == ((u16 *)(addr2))[2]))))

total: 0 errors, 0 warnings, 3 checks, 93 lines checked

           reply	other threads:[~2019-08-26 10:55 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190826105105.19121-42-qi.z.zhang@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826105517.484AC1D176@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).