automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gagandeep Singh <g.singh@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw57981 [PATCH v1 06/13] net/ppfe: add MAC and host interface initialisation
Date: Mon, 26 Aug 2019 15:18:06 +0200 (CEST)	[thread overview]
Message-ID: <20190826131806.5C9301C2BF@dpdk.org> (raw)
In-Reply-To: <20190826130246.30485-7-g.singh@nxp.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57981

_coding style issues_


ERROR:SPACING: space required before the open brace '{'
#367: FILE: drivers/net/ppfe/pfe_hal.c:172:
+	} else{

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#646: FILE: drivers/net/ppfe/pfe_hal.c:451:
+	if (pfe_svr == SVR_LS1012A_REV1) {
[...]
+	} else {
[...]

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'd' - possible side-effects?
#809: FILE: drivers/net/ppfe/pfe_hif.c:11:
+#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))

WARNING:UNNECESSARY_INT: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary
#922: FILE: drivers/net/ppfe/pfe_hif.c:124:
+	lmem_virt_addr = (void *)CBUS_PFE_TO_VIRT((unsigned long int)lmem_ptr);

WARNING:UNNECESSARY_INT: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary
#940: FILE: drivers/net/ppfe/pfe_hif.c:142:
+	writel((unsigned long int)lmem_ptr, CLASS_INQ_PKTPTR);

total: 1 errors, 3 warnings, 1 checks, 1508 lines checked

           reply	other threads:[~2019-08-26 13:18 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190826130246.30485-7-g.singh@nxp.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826131806.5C9301C2BF@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=g.singh@nxp.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).