From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C413DA0613
	for <public@inbox.dpdk.org>; Mon, 26 Aug 2019 15:18:10 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BDC951C1A0;
	Mon, 26 Aug 2019 15:18:09 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 5C9301C2BF; Mon, 26 Aug 2019 15:18:06 +0200 (CEST)
In-Reply-To: <20190826130246.30485-7-g.singh@nxp.com>
References: <20190826130246.30485-7-g.singh@nxp.com>
To: test-report@dpdk.org
Cc: Gagandeep Singh <g.singh@nxp.com>
Message-Id: <20190826131806.5C9301C2BF@dpdk.org>
Date: Mon, 26 Aug 2019 15:18:06 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw57981 [PATCH v1 06/13] net/ppfe: add
	MAC and host interface initialisation
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57981

_coding style issues_


ERROR:SPACING: space required before the open brace '{'
#367: FILE: drivers/net/ppfe/pfe_hal.c:172:
+	} else{

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#646: FILE: drivers/net/ppfe/pfe_hal.c:451:
+	if (pfe_svr == SVR_LS1012A_REV1) {
[...]
+	} else {
[...]

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'd' - possible side-effects?
#809: FILE: drivers/net/ppfe/pfe_hif.c:11:
+#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))

WARNING:UNNECESSARY_INT: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary
#922: FILE: drivers/net/ppfe/pfe_hif.c:124:
+	lmem_virt_addr = (void *)CBUS_PFE_TO_VIRT((unsigned long int)lmem_ptr);

WARNING:UNNECESSARY_INT: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary
#940: FILE: drivers/net/ppfe/pfe_hif.c:142:
+	writel((unsigned long int)lmem_ptr, CLASS_INQ_PKTPTR);

total: 1 errors, 3 warnings, 1 checks, 1508 lines checked