From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F1A3A0613 for ; Wed, 28 Aug 2019 10:20:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7478F1C21D; Wed, 28 Aug 2019 10:20:13 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 0852A1C22D; Wed, 28 Aug 2019 10:20:12 +0200 (CEST) In-Reply-To: <1566975109-318949-2-git-send-email-bingz@mellanox.com> References: <1566975109-318949-2-git-send-email-bingz@mellanox.com> To: test-report@dpdk.org Cc: Bing Zhao Message-Id: <20190828082012.0852A1C22D@dpdk.org> Date: Wed, 28 Aug 2019 10:20:12 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw58107 [RFC] rte_hash: introduce hash list into hash lib X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/58107 _coding style issues_ WARNING:TYPO_SPELLING: 'splitted' may be misspelled - perhaps 'split'? #230: FILE: lib/librte_hash/rte_hlist.c:148: + * Others will be checked and splitted when being accessed. WARNING:TYPO_SPELLING: 'splitted' may be misspelled - perhaps 'split'? #251: FILE: lib/librte_hash/rte_hlist.c:169: + * not splitted should be splitted(no matter if any entry in). WARNING:TYPO_SPELLING: 'splitted' may be misspelled - perhaps 'split'? #251: FILE: lib/librte_hash/rte_hlist.c:169: + * not splitted should be splitted(no matter if any entry in). WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #837: FILE: lib/librte_hash/rte_hlist.h:62: +#define RETURN_IF_TRUE(cond, retval) do { \ + if (cond) \ + return retval; \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #842: FILE: lib/librte_hash/rte_hlist.h:67: +#define RETURN_IF_TRUE_ERRNO(cond, retval, err) do { \ + if (cond) { \ + rte_errno = err; \ + return retval; \ + } \ + } while (0) WARNING:TYPO_SPELLING: 'fuction' may be misspelled - perhaps 'function'? #1121: FILE: lib/librte_hash/rte_hlist.h:346: + * - -EBUSY if there is custom data but without custom free fuction. total: 0 errors, 6 warnings, 1282 lines checked INFO: symbol 0, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol break is added in the h->key_len)) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol break is added in the i) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol break is added in the (len) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol break is added in the next) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol break is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol char is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol char is added in the rte_hlist_node_entry section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol char is added in the rte_hlist_table section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol const is added in the rte_hlist_params section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol *data is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol *data is added in the pos->d.flags) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol d->extra_data is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol d->flags is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol -EINVAL) is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol "Failed is added in the 0) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol "Failed is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol for is added in the "C" section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol goto is added in the 0) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol goto is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol hash_sig_t is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol h->bucket_mask is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol (h->bucket_shift is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol h->bucket_shift is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol h->custom_entries++ is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol h->custom_entries-- is added in the pos->d.flags) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol h->custom_entries++ is added in the TRUE) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol h->custom_entries-- is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol he is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol he->entries_in_bucket-- is added in the idx) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol he->entries_in_bucket-- is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol he->entries_in_bucket++ is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol he is added in the i) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol h->entries is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol he is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol h->free_func is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol h->free_func(pos->d.extra_data) is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol HLIST_CALC_PREVIOUS_BUCKET_MASK(h->bucket_mask, is added in the i) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol hlist_list is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol ht->bucket_mask is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol ht->entries_per_bucket is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol ht->entries is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol ht->free_func is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol ht->hash_func is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol ht->hash_func is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol h->t[idx].entries_in_bucket-- is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol ht->init_val is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol ht->init_val is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol ht->key_len is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol h->t[new_idx].bucket_shift is added in the i) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol ht is added in the next) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol h->t is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol ht is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol idx is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol idx is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol int is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol int is added in the rte_hlist_params section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol LIST_ENTRY(rte_hlist_node_entry) is added in the rte_hlist_node_entry section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol LIST_HEAD(, is added in the rte_hlist_head_entry section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol LIST_INSERT_HEAD(&he->head, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol LIST_INSERT_HEAD(&n_he->head, is added in the idx) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol LIST_MOVE_TO_NEW_HEAD(&he->head, is added in the 0) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol LIST_MOVE_TO_NEW_HEAD(&he->head, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol LIST_REMOVE(pos, is added in the idx) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol LIST_REMOVE(pos, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol matched is added in the h->key_len)) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol new_idx is added in the i) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol new_idx is added in the tp) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol (new)->lh_first is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol (new)->lh_first->field.le_prev is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol n_he->entries_in_bucket++ is added in the idx) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol n_he is added in the i) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol n_he is added in the idx) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol n_he is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol n_idx is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol pos is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol pos->d.extra_data is added in the (len) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol pos->d.extra_data) is added in the pos->d.flags) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol pos->d.extra_data is added in the TRUE) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol pos->d.extra_data is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol pos->d.flags is added in the 0) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol pos->d.flags is added in the 0)) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol pos->d.flags is added in the TRUE) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol pos->d.flags is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol pos->d.sig is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol pos->d.v16 is added in the (len) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol pos->d.v32 is added in the (len) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol pos->d.v64 is added in the (len) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol pos->d.v8 is added in the (len) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol *p is added in the TRUE) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol *p is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol ret is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol ret is added in the h->bucket_shift) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol ret is added in the h->bucket_shift)) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol ret is added in the TRUE) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol ret is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol return is added in the 0) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol return is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol return is added in the he->bucket_shift) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol RETURN_IF_TRUE_ERRNO(((h is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol RETURN_IF_TRUE(((h is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol RETURN_IF_TRUE((h is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol return is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol return is added in the NULL)) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol return is added in the RTE_HLIST_ENTRIES_PER_BUCKET_MAX)) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol return is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol rte_errno is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_errno is added in the he->bucket_shift) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_errno is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_errno is added in the NULL)) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_errno is added in the RTE_HLIST_ENTRIES_PER_BUCKET_MAX)) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_free(ht) is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol rte_free(h) is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol rte_free(pos->d.extra_data) is added in the (HLIST_DATA_IS_ALLOCATED(&pos->d)) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol rte_free(pos->d.extra_data) is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol rte_free(pos) is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol rte_free(pos) is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol rte_free(te) is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol rte_free(te) is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol rte_hlist_add_key_data has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_add_key_data_len has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_add_key has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_add_key_with_hash_data has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_add_key_with_hash_data_len has been added to the EXPERIMENTAL section of the version map ERROR: symbol rte_hlist_calc_fn is added in the rte_hlist_params section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_hlist_calc_fn is added in the rte_hlist_table section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_clear_all_entries_with_cb has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_create has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_del_entry_fast_return_data has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_del_key has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_del_key_return_data has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_free has been added to the EXPERIMENTAL section of the version map ERROR: symbol rte_hlist_free_fn is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_hlist_free_fn is added in the rte_hlist_params section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_hlist_free_fn is added in the rte_hlist_table section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_free_fn is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol rte_hlist_free(struct is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol rte_hlist_hash has been added to the EXPERIMENTAL section of the version map ERROR: symbol rte_hlist_hash(h, is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol rte_hlist_list) is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_lookup has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_lookup_with_hash has been added to the EXPERIMENTAL section of the version map INFO: symbol rte_hlist_table is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol RTE_LOG(ERR, is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol rte_memcpy(pos->d.extra_data, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol rte_memcpy(pos->key, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK) is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK) is added in the NULL) section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK) is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol rte_tailq_entry) is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol saved_fn is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol sh_gap_mul is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol sh is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol sizeof(struct is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol sizeof(struct is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol size is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol snprintf(hash_name, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol snprintf(ht->name, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol struct is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol struct is added in the rte_hlist_node_entry section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol struct is added in the rte_hlist_table section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol struct is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol table_size is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol TAILQ_INSERT_TAIL(hlist_list, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol TAILQ_REMOVE(hlist_list, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL INFO: symbol te->data is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol uint16_t is added in the rte_hlist_head_entry section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol uint16_t is added in the rte_hlist_table section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol uint16_t is added in the union section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol uint32_t is added in the { section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol uint32_t is added in the h->bucket_shift) section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol uint32_t is added in the rte_hlist_params section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol uint32_t is added in the rte_hlist_table section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol uint32_t is added in the union section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol uint32_t is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol uint64_t is added in the union section, but is expected to be added in the EXPERIMENTAL section of the version map ERROR: symbol uint8_t is added in the union section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol } is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol (var) is added in the "C" section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol (void)__rte_hlist_clear_all_entries(h, is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol void is added in the union section, but is expected to be added in the EXPERIMENTAL section of the version map INFO: symbol void is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL