From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD319A2EDB for ; Fri, 6 Sep 2019 09:26:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E6A21F0A2; Fri, 6 Sep 2019 09:26:53 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id C56491F16F; Fri, 6 Sep 2019 09:26:50 +0200 (CEST) In-Reply-To: <20190906072548.12304-4-rmody@marvell.com> References: <20190906072548.12304-4-rmody@marvell.com> To: test-report@dpdk.org Cc: Rasesh Mody Message-Id: <20190906072650.C56491F16F@dpdk.org> Date: Fri, 6 Sep 2019 09:26:50 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw58736 [PATCH 3/5] net/bnx2x: update to latest FW 7.13.11 X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/58736 _coding style issues_ WARNING:TYPO_SPELLING: 'boundry' may be misspelled - perhaps 'boundary'? #127: FILE: drivers/net/bnx2x/bnx2x.c:11562: + ecore_ilt_boundry_init_op(sc, &ilt_cli, 0, INITOP_CLEAR); CHECK:CAMELCASE: Avoid CamelCase: #167: FILE: drivers/net/bnx2x/ecore_fw_defs.h:18: + (IRO[151].base + ((assertListEntry) * IRO[151].m1)) CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #171: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: + (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #171: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: + (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ ^ CHECK:CAMELCASE: Avoid CamelCase: #171: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20: + (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \ CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #182: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23: + (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #182: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23: + (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \ ^ CHECK:CAMELCASE: Avoid CamelCase: #186: FILE: drivers/net/bnx2x/ecore_fw_defs.h:26: + (IRO[163].base + ((funcId) * IRO[163].m1)) CHECK:CAMELCASE: Avoid CamelCase: #192: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30: + (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2)) CHECK:CAMELCASE: Avoid CamelCase: #192: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30: + (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2)) CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #197: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32: + (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #197: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32: + (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \ ^ CHECK:CAMELCASE: Avoid CamelCase: #208: FILE: drivers/net/bnx2x/ecore_fw_defs.h:40: + (IRO[316].base + ((pfId) * IRO[316].m1) + ((iscsiEqId) * IRO[316].m2)) CHECK:CAMELCASE: Avoid CamelCase: #280: FILE: drivers/net/bnx2x/ecore_fw_defs.h:87: +#define CSTORM_VF_PF_CHANNEL_STATE_OFFSET(vfId) \ CHECK:CAMELCASE: Avoid CamelCase: #361: FILE: drivers/net/bnx2x/ecore_fw_defs.h:142: + (IRO[187].base + ((portId) * IRO[187].m1)) CHECK:CAMELCASE: Avoid CamelCase: #407: FILE: drivers/net/bnx2x/ecore_fw_defs.h:172: + (IRO[215].base + ((portId) * IRO[215].m1) + ((clientId) * \ CHECK:CAMELCASE: Avoid CamelCase: #413: FILE: drivers/net/bnx2x/ecore_fw_defs.h:175: + (IRO[216].base + ((qzoneId) * IRO[216].m1)) CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV) #491: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241: + (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #491: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241: + (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \ ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #519: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: + (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #519: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: + (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #519: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268: + (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1)) ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #523: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: +#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #523: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272: +#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8)) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #527: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276: +#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1) ^ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #570: FILE: drivers/net/bnx2x/ecore_fw_defs.h:378: +#define TSDM_TIMER_TICK_RESUL_CHIP (1 * (1e-6)) ^ CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #745: FILE: drivers/net/bnx2x/ecore_init.h:582: + en_mask, {m1, m1h, m2, m3}, #block"_0" \ CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #754: FILE: drivers/net/bnx2x/ecore_init.h:589: + en_mask, {m1, m1h, m2, m3}, #block"_1" \ CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #853: FILE: drivers/net/bnx2x/ecore_init.h:645: + BLOCK_PRTY_INFO(PRS, (1<<6), 0xff, 0xff, 0xff, 0xff), ^ WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #1023: FILE: drivers/net/bnx2x/ecore_init_ops.h:18: +#if 0 WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #1034: FILE: drivers/net/bnx2x/ecore_init_ops.h:34: +#if 0 CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #1041: FILE: drivers/net/bnx2x/ecore_init_ops.h:41: + ecore_reg_wr_ind(sc, addr + i*4, data[i]); ^ WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #1045: FILE: drivers/net/bnx2x/ecore_init_ops.h:45: +#if 0 WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #1057: FILE: drivers/net/bnx2x/ecore_init_ops.h:56: +#if 0 CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #1079: FILE: drivers/net/bnx2x/ecore_init_ops.h:79: + ecore_write_big_buf(sc, addr + i*4, cur_len, wb); ^ WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #1088: FILE: drivers/net/bnx2x/ecore_init_ops.h:88: +#if 0 WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #1105: FILE: drivers/net/bnx2x/ecore_init_ops.h:174: +#if 0 CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r_order == MAX_RD_ORD' #1154: FILE: drivers/net/bnx2x/ecore_init_ops.h:536: + if ((CHIP_IS_E1(sc) || CHIP_IS_E1H(sc)) && (r_order == MAX_RD_ORD)) CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #1281: FILE: drivers/net/bnx2x/ecore_init_ops.h:659: + reg = PXP2_REG_RQ_ONCHIP_AT + abs_idx*8; ^ CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #1283: FILE: drivers/net/bnx2x/ecore_init_ops.h:661: + reg = PXP2_REG_RQ_ONCHIP_AT_B0 + abs_idx*8; ^ WARNING:TYPO_SPELLING: 'boundry' may be misspelled - perhaps 'boundary'? #1351: FILE: drivers/net/bnx2x/ecore_init_ops.h:754: + ecore_ilt_boundry_init_op(sc, ilt_cli, ilt->start_line, initop); WARNING:LONG_LINE_COMMENT: line over 90 characters #1433: FILE: drivers/net/bnx2x/ecore_mfw_req.h:150: +#define ISCSI_IP_ADDRESS_TYPE_NOT_SET (0 << 30) /* Driver does not have the IP address and type populated */ WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #1565: FILE: drivers/net/bnx2x/ecore_sp.h:138: +#if 0 CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #1574: FILE: drivers/net/bnx2x/ecore_sp.h:155: +#define ECORE_ILT_ZALLOC(x, y, size) \ + do { \ + x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \ + if (x) { \ + if (bnx2x_dma_alloc((struct bnx2x_softc *)sc, \ + size, (struct bnx2x_dma *)x, \ + "ILT", RTE_CACHE_LINE_SIZE) != 0) { \ + rte_free(x); \ + x = NULL; \ + *y = 0; \ + } else { \ + *y = ((struct bnx2x_dma *)x)->paddr; \ + } \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects? #1574: FILE: drivers/net/bnx2x/ecore_sp.h:155: +#define ECORE_ILT_ZALLOC(x, y, size) \ + do { \ + x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \ + if (x) { \ + if (bnx2x_dma_alloc((struct bnx2x_softc *)sc, \ + size, (struct bnx2x_dma *)x, \ + "ILT", RTE_CACHE_LINE_SIZE) != 0) { \ + rte_free(x); \ + x = NULL; \ + *y = 0; \ + } else { \ + *y = ((struct bnx2x_dma *)x)->paddr; \ + } \ + } \ + } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'y' may be better as '(y)' to avoid precedence issues #1574: FILE: drivers/net/bnx2x/ecore_sp.h:155: +#define ECORE_ILT_ZALLOC(x, y, size) \ + do { \ + x = rte_malloc("", sizeof(struct bnx2x_dma), RTE_CACHE_LINE_SIZE); \ + if (x) { \ + if (bnx2x_dma_alloc((struct bnx2x_softc *)sc, \ + size, (struct bnx2x_dma *)x, \ + "ILT", RTE_CACHE_LINE_SIZE) != 0) { \ + rte_free(x); \ + x = NULL; \ + *y = 0; \ + } else { \ + *y = ((struct bnx2x_dma *)x)->paddr; \ + } \ + } \ + } while (0) WARNING:TYPO_SPELLING: 'successfull' may be misspelled - perhaps 'successful'? #2206: FILE: drivers/net/bnx2x/ecore_sp.h:1938: + * Return: 0 is operation was successfull and there are no pending completions, CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects? #2238: FILE: drivers/net/bnx2x/ecore_sp.h:1982: +#define PF_MAC_CREDIT_E2(sc, func_num) \ + ((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_MAC_CREDIT_CNT) / \ + func_num + GET_NUM_VFS_PER_PF(sc) * VF_MAC_CREDIT_CNT) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func_num' may be better as '(func_num)' to avoid precedence issues #2238: FILE: drivers/net/bnx2x/ecore_sp.h:1982: +#define PF_MAC_CREDIT_E2(sc, func_num) \ + ((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_MAC_CREDIT_CNT) / \ + func_num + GET_NUM_VFS_PER_PF(sc) * VF_MAC_CREDIT_CNT) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects? #2242: FILE: drivers/net/bnx2x/ecore_sp.h:1986: +#define PF_VLAN_CREDIT_E2(sc, func_num) \ + ((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_VLAN_CREDIT_CNT) / \ + func_num + GET_NUM_VFS_PER_PF(sc) * VF_VLAN_CREDIT_CNT) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func_num' may be better as '(func_num)' to avoid precedence issues #2242: FILE: drivers/net/bnx2x/ecore_sp.h:1986: +#define PF_VLAN_CREDIT_E2(sc, func_num) \ + ((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_VLAN_CREDIT_CNT) / \ + func_num + GET_NUM_VFS_PER_PF(sc) * VF_VLAN_CREDIT_CNT) total: 0 errors, 11 warnings, 40 checks, 2050 lines checked