From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 417A6A2EFC for ; Fri, 20 Sep 2019 15:34:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39D051F455; Fri, 20 Sep 2019 15:34:01 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 9AD581F498; Fri, 20 Sep 2019 15:33:59 +0200 (CEST) In-Reply-To: <1568985955-13548-22-git-send-email-xavier.huwei@huawei.com> References: <1568985955-13548-22-git-send-email-xavier.huwei@huawei.com> To: test-report@dpdk.org Cc: "Wei Hu (Xavier)" Message-Id: <20190920133359.9AD581F498@dpdk.org> Date: Fri, 20 Sep 2019 15:33:59 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw59528 [PATCH v2 21/22] net/hns3: add reset related process for hns3 PMD driver X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/59528 _coding style issues_ CHECK:BRACES: braces {} should be used on all arms of this statement #198: FILE: drivers/net/hns3/hns3_ethdev.c:215: + if (event_cause == HNS3_VECTOR0_EVENT_ERR) { [...] + } else if (event_cause == HNS3_VECTOR0_EVENT_RST) [...] + else [...] CHECK:BRACES: braces {} should be used on all arms of this statement #295: FILE: drivers/net/hns3/hns3_ethdev.c:3778: + if (!hns3_is_reset_pending(hns)) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #298: FILE: drivers/net/hns3/hns3_ethdev.c:3781: + } else CHECK:BRACES: braces {} should be used on all arms of this statement #319: FILE: drivers/net/hns3/hns3_ethdev.c:4048: + if (rte_atomic16_read(&hw->reset.disable_cmd) == 0) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #322: FILE: drivers/net/hns3/hns3_ethdev.c:4051: + } else CHECK:BRACES: braces {} should be used on all arms of this statement #467: FILE: drivers/net/hns3/hns3_ethdev.c:4388: + if (wait_data->result == HNS3_WAIT_SUCCESS) [...] + else if (wait_data->result == HNS3_WAIT_TIMEOUT) { [...] + } else if (wait_data->result == HNS3_WAIT_REQUEST) [...] CHECK:BRACES: braces {} should be used on all arms of this statement #634: FILE: drivers/net/hns3/hns3_ethdev.c:4555: + if (hns->hw.adapter_state == HNS3_NIC_STARTED || [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #638: FILE: drivers/net/hns3/hns3_ethdev.c:4559: + } else CHECK:BRACES: braces {} should be used on all arms of this statement #698: FILE: drivers/net/hns3/hns3_ethdev.c:4619: + if (hns->hw.adapter_state == HNS3_NIC_STARTED) { [...] + } else if (hw->adapter_state == HNS3_NIC_STOPPING) [...] CHECK:CAMELCASE: Avoid CamelCase: #757: FILE: drivers/net/hns3/hns3_ethdev.c:4678: + hns3_err(hw, "%d handle long time delta %" PRIx64 CHECK:BRACES: braces {} should be used on all arms of this statement #1055: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1132: + if (rte_atomic16_read(&hw->reset.disable_cmd) == 0) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #1058: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1135: + } else CHECK:BRACES: braces {} should be used on all arms of this statement #1156: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1306: + if (wait_data->result == HNS3_WAIT_SUCCESS) [...] + else if (wait_data->result == HNS3_WAIT_TIMEOUT) { [...] + } else if (wait_data->result == HNS3_WAIT_REQUEST) [...] CHECK:BRACES: braces {} should be used on all arms of this statement #1205: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1355: + if (hw->adapter_state == HNS3_NIC_STARTED || [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #1209: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1359: + } else CHECK:BRACES: braces {} should be used on all arms of this statement #1259: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1409: + if (hw->adapter_state == HNS3_NIC_STARTED) { [...] + } else if (hw->adapter_state == HNS3_NIC_STOPPING) [...] CHECK:BRACES: braces {} should be used on all arms of this statement #1522: FILE: drivers/net/hns3/hns3_intr.c:732: + if (data->check_completion) { [...] + } else [...] CHECK:BRACES: braces {} should be used on all arms of this statement #1528: FILE: drivers/net/hns3/hns3_intr.c:738: + if (msec > data->end_ms || is_reset_pending(hns) || [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #1532: FILE: drivers/net/hns3/hns3_intr.c:742: + } else CHECK:BRACES: Unbalanced braces around else statement #1534: FILE: drivers/net/hns3/hns3_intr.c:744: + } else CHECK:BRACES: braces {} should be used on all arms of this statement #1541: FILE: drivers/net/hns3/hns3_intr.c:751: + if (done) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #1543: FILE: drivers/net/hns3/hns3_intr.c:753: + else { CHECK:BRACES: braces {} should be used on all arms of this statement #1570: FILE: drivers/net/hns3/hns3_intr.c:780: + if (hw->reset.wait_data->result == HNS3_WAIT_UNKNOWN) { [...] + } else if (hw->reset.wait_data->result == HNS3_WAIT_REQUEST) [...] total: 0 errors, 0 warnings, 23 checks, 1936 lines checked