* [dpdk-test-report] |WARNING| pw59796 [RFC 2/2] net/vhost_ioat: add vhost I/OAT driver
[not found] <1569507973-247570-3-git-send-email-jiayu.hu@intel.com>
@ 2019-09-27 12:04 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-09-27 12:04 UTC (permalink / raw)
To: test-report; +Cc: Jiayu Hu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/59796
_coding style issues_
WARNING:TYPO_SPELLING: 'tranfer' may be misspelled - perhaps 'transfer'?
#26:
there is no CPU intervention during data tranfer. Thus, we can save
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#53:
--vdev 'ioat_vhost0,iface=/tmp/sock0,queues=2,ioats=(txq0@00:04.0;txq1@00:04.1),client=0'
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#199: FILE: drivers/net/vhost_ioat/eth_vhost.c:33:
+static const char *valid_arguments[] = {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#812: FILE: drivers/net/vhost_ioat/eth_vhost.c:646:
+ unsigned i;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#875: FILE: drivers/net/vhost_ioat/eth_vhost.c:709:
+ unsigned i;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1143: FILE: drivers/net/vhost_ioat/eth_vhost.c:977:
+ unsigned i;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1184: FILE: drivers/net/vhost_ioat/eth_vhost.c:1018:
+ unsigned i;
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vr' - possible side-effects?
#1658: FILE: drivers/net/vhost_ioat/eth_vhost.h:47:
+#define vhost_avail_event(vr) \
+ (*(volatile uint16_t*)&(vr)->used->ring[(vr)->size])
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vr' - possible side-effects?
#1660: FILE: drivers/net/vhost_ioat/eth_vhost.h:49:
+#define vhost_used_event(vr) \
+ (*(volatile uint16_t*)&(vr)->avail->ring[(vr)->size])
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0'
#2153: FILE: drivers/net/vhost_ioat/virtio_net.c:50:
+ if ((vhost_need_event(vhost_used_event(vr), new, old) &&
+ (vr->callfd >= 0)) || unlikely(!signalled_used_valid))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0'
#2157: FILE: drivers/net/vhost_ioat/virtio_net.c:54:
+ if (!(vr->avail->flags & VRING_AVAIL_F_NO_INTERRUPT) &&
+ (vr->callfd >= 0))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects?
#2316: FILE: drivers/net/vhost_ioat/virtio_net.c:213:
+#define ASSIGN_UNLESS_EQUAL(var, val) do { \
+ if ((var) != (val)) \
+ (var) = (val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#2316: FILE: drivers/net/vhost_ioat/virtio_net.c:213:
+#define ASSIGN_UNLESS_EQUAL(var, val) do { \
+ if ((var) != (val)) \
+ (var) = (val); \
+} while (0)
total: 0 errors, 7 warnings, 3230 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-09-27 12:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1569507973-247570-3-git-send-email-jiayu.hu@intel.com>
2019-09-27 12:04 ` [dpdk-test-report] |WARNING| pw59796 [RFC 2/2] net/vhost_ioat: add vhost I/OAT driver checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).