From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D27A6A0613 for ; Fri, 27 Sep 2019 14:04:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD2AB1BF19; Fri, 27 Sep 2019 14:04:46 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id D4DAC1BEE1; Fri, 27 Sep 2019 14:04:38 +0200 (CEST) In-Reply-To: <1569507973-247570-3-git-send-email-jiayu.hu@intel.com> References: <1569507973-247570-3-git-send-email-jiayu.hu@intel.com> To: test-report@dpdk.org Cc: Jiayu Hu Message-Id: <20190927120438.D4DAC1BEE1@dpdk.org> Date: Fri, 27 Sep 2019 14:04:38 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw59796 [RFC 2/2] net/vhost_ioat: add vhost I/OAT driver X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/59796 _coding style issues_ WARNING:TYPO_SPELLING: 'tranfer' may be misspelled - perhaps 'transfer'? #26: there is no CPU intervention during data tranfer. Thus, we can save WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #53: --vdev 'ioat_vhost0,iface=/tmp/sock0,queues=2,ioats=(txq0@00:04.0;txq1@00:04.1),client=0' WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const #199: FILE: drivers/net/vhost_ioat/eth_vhost.c:33: +static const char *valid_arguments[] = { WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #812: FILE: drivers/net/vhost_ioat/eth_vhost.c:646: + unsigned i; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #875: FILE: drivers/net/vhost_ioat/eth_vhost.c:709: + unsigned i; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1143: FILE: drivers/net/vhost_ioat/eth_vhost.c:977: + unsigned i; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1184: FILE: drivers/net/vhost_ioat/eth_vhost.c:1018: + unsigned i; CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vr' - possible side-effects? #1658: FILE: drivers/net/vhost_ioat/eth_vhost.h:47: +#define vhost_avail_event(vr) \ + (*(volatile uint16_t*)&(vr)->used->ring[(vr)->size]) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vr' - possible side-effects? #1660: FILE: drivers/net/vhost_ioat/eth_vhost.h:49: +#define vhost_used_event(vr) \ + (*(volatile uint16_t*)&(vr)->avail->ring[(vr)->size]) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0' #2153: FILE: drivers/net/vhost_ioat/virtio_net.c:50: + if ((vhost_need_event(vhost_used_event(vr), new, old) && + (vr->callfd >= 0)) || unlikely(!signalled_used_valid)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0' #2157: FILE: drivers/net/vhost_ioat/virtio_net.c:54: + if (!(vr->avail->flags & VRING_AVAIL_F_NO_INTERRUPT) && + (vr->callfd >= 0)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects? #2316: FILE: drivers/net/vhost_ioat/virtio_net.c:213: +#define ASSIGN_UNLESS_EQUAL(var, val) do { \ + if ((var) != (val)) \ + (var) = (val); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects? #2316: FILE: drivers/net/vhost_ioat/virtio_net.c:213: +#define ASSIGN_UNLESS_EQUAL(var, val) do { \ + if ((var) != (val)) \ + (var) = (val); \ +} while (0) total: 0 errors, 7 warnings, 3230 lines checked