From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DDAFA2EFE for ; Mon, 30 Sep 2019 04:50:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8DCEE5681; Mon, 30 Sep 2019 04:50:46 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 61ECA3977; Mon, 30 Sep 2019 04:50:45 +0200 (CEST) In-Reply-To: <20190930024921.21818-9-rmody@marvell.com> References: <20190930024921.21818-9-rmody@marvell.com> To: test-report@dpdk.org Cc: Rasesh Mody Message-Id: <20190930025045.61ECA3977@dpdk.org> Date: Mon, 30 Sep 2019 04:50:45 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw60121 [PATCH 8/9] net/qede/base: update the FW to 8.40.25.0 X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/60121 _coding style issues_ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #468: FILE: drivers/net/qede/base/ecore_cxt.c:633: + p_blk = ecore_cxt_set_blk( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #496: FILE: drivers/net/qede/base/ecore_cxt.c:688: + p_blk = ecore_cxt_set_blk( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'line == first_skipped_line' #829: FILE: drivers/net/qede/base/ecore_cxt.c:1018: + if (lines_to_skip && (line == first_skipped_line)) { WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'ecore_hw_init_chip', this function's name, in a string #1517: FILE: drivers/net/qede/base/ecore_dev.c:2719: + "ecore_hw_init_chip() shouldn't be called in a non-emulation environment "); CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pq_size' - possible side-effects? #2383: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:26: +#define QM_PQ_MEM_4KB(pq_size) \ + (pq_size ? DIV_ROUND_UP((pq_size + 1) * QM_PQ_ELEMENT_SIZE, 0x1000) : 0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pq_size' - possible side-effects? #2385: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:28: +#define QM_PQ_SIZE_256B(pq_size) \ + (pq_size ? DIV_ROUND_UP(pq_size, 0x100) - 1 : 0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rl_id' - possible side-effects? #2445: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:171: +#define PQ_INFO_ELEMENT(vp_pq_id, pf, tc, port, rl_valid, rl_id) \ + (((vp_pq_id) << 0) | ((pf) << 12) | ((tc) << 16) | ((port) << 20) | \ + ((rl_valid ? 1 : 0) << 22) | (((rl_id) & 255) << 24) | \ + (((rl_id) >> 8) << 9)) CHECK:CAMELCASE: Avoid CamelCase: #3141: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1438: + u32 *pData, CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects? #3559: FILE: drivers/net/qede/base/ecore_init_fw_funcs.h:20: +#define VOQ(port, tc, max_phys_tcs_per_port) \ + ((tc) == PURE_LB_TC ? NUM_OF_PHYS_TCS * MAX_NUM_PORTS_BB + (port) : \ + (port) * (max_phys_tcs_per_port) + (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #3559: FILE: drivers/net/qede/base/ecore_init_fw_funcs.h:20: +#define VOQ(port, tc, max_phys_tcs_per_port) \ + ((tc) == PURE_LB_TC ? NUM_OF_PHYS_TCS * MAX_NUM_PORTS_BB + (port) : \ + (port) * (max_phys_tcs_per_port) + (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'params' - possible side-effects? #4881: FILE: drivers/net/qede/base/ecore_mcp.h:86: +#define ECORE_MB_FLAGS_IS_SET(params, flag) \ + ((params) != OSAL_NULL && ((params)->flags & ECORE_MB_FLAG_##flag)) total: 0 errors, 1 warnings, 10 checks, 4964 lines checked