From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Rasesh Mody <rmody@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw60588 [PATCH v2 8/9] net/qede/base: update the FW to 8.40.25.0
Date: Sun, 6 Oct 2019 22:16:13 +0200 (CEST) [thread overview]
Message-ID: <20191006201613.5B3EB1D15E@dpdk.org> (raw)
In-Reply-To: <20191006201409.8770-9-rmody@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/60588
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'line == first_skipped_line'
#829: FILE: drivers/net/qede/base/ecore_cxt.c:1018:
+ if (lines_to_skip && (line == first_skipped_line)) {
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'ecore_hw_init_chip', this function's name, in a string
#1517: FILE: drivers/net/qede/base/ecore_dev.c:2719:
+ "ecore_hw_init_chip() shouldn't be called in a non-emulation environment
");
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pq_size' - possible side-effects?
#2383: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:26:
+#define QM_PQ_MEM_4KB(pq_size) \
+ (pq_size ? DIV_ROUND_UP((pq_size + 1) * QM_PQ_ELEMENT_SIZE, 0x1000) : 0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pq_size' - possible side-effects?
#2385: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:28:
+#define QM_PQ_SIZE_256B(pq_size) \
+ (pq_size ? DIV_ROUND_UP(pq_size, 0x100) - 1 : 0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rl_id' - possible side-effects?
#2445: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:172:
+#define PQ_INFO_ELEMENT(vp_pq_id, pf, tc, port, rl_valid, rl_id) \
+ (((vp_pq_id) << 0) | ((pf) << 12) | ((tc) << 16) | ((port) << 20) | \
+ ((rl_valid ? 1 : 0) << 22) | (((rl_id) & 255) << 24) | \
+ (((rl_id) >> 8) << 9))
CHECK:CAMELCASE: Avoid CamelCase: <pData>
#3141: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1439:
+ u32 *pData,
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'port' - possible side-effects?
#3559: FILE: drivers/net/qede/base/ecore_init_fw_funcs.h:20:
+#define VOQ(port, tc, max_phys_tcs_per_port) \
+ ((tc) == PURE_LB_TC ? NUM_OF_PHYS_TCS * MAX_NUM_PORTS_BB + (port) : \
+ (port) * (max_phys_tcs_per_port) + (tc))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#3559: FILE: drivers/net/qede/base/ecore_init_fw_funcs.h:20:
+#define VOQ(port, tc, max_phys_tcs_per_port) \
+ ((tc) == PURE_LB_TC ? NUM_OF_PHYS_TCS * MAX_NUM_PORTS_BB + (port) : \
+ (port) * (max_phys_tcs_per_port) + (tc))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'params' - possible side-effects?
#4881: FILE: drivers/net/qede/base/ecore_mcp.h:86:
+#define ECORE_MB_FLAGS_IS_SET(params, flag) \
+ ((params) != OSAL_NULL && ((params)->flags & ECORE_MB_FLAG_##flag))
total: 0 errors, 1 warnings, 8 checks, 4964 lines checked
parent reply other threads:[~2019-10-06 20:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20191006201409.8770-9-rmody@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006201613.5B3EB1D15E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=rmody@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).