automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw60693 [PATCH v3 5/5] app: add test-sad application
       [not found] <8510ca9bb2d60cf38d6023c487a963c08f426fc4.1570527218.git.vladimir.medvedkin@intel.com>
@ 2019-10-08  9:42 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2019-10-08  9:42 UTC (permalink / raw)
  To: test-report; +Cc: Vladimir Medvedkin

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/60693

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#111: FILE: app/test-sad/main.c:24:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {		\
+	unsigned long val;					\
+	char *end_fld;						\
+	errno = 0;						\
+	val = strtoul((in), &end_fld, (base));			\
+	if (errno != 0 || end_fld[0] != (dlm) || val > (lim))	\
+		return -EINVAL;					\
+	(fd) = (typeof(fd))val;					\
+	(in) = end_fld + 1;					\
+} while (0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#319: FILE: app/test-sad/main.c:232:
+	unsigned i, j, rnd;

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'lookup', this function's name, in a string
#628: FILE: app/test-sad/main.c:541:
+	printf("Average lookup cycles %.2Lf, lookups/sec: %.2Lf
",

total: 0 errors, 3 warnings, 702 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-10-08  9:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <8510ca9bb2d60cf38d6023c487a963c08f426fc4.1570527218.git.vladimir.medvedkin@intel.com>
2019-10-08  9:42 ` [dpdk-test-report] |WARNING| pw60693 [PATCH v3 5/5] app: add test-sad application checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).