From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 09022A2F6B
	for <public@inbox.dpdk.org>; Tue,  8 Oct 2019 18:56:42 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0227E1D483;
	Tue,  8 Oct 2019 18:56:42 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id ED0A01E53E; Tue,  8 Oct 2019 18:56:38 +0200 (CEST)
In-Reply-To: <b9a036a847a4f91b96d500acc10b2330e25da358.1570553345.git.vladimir.medvedkin@intel.com>
References: <b9a036a847a4f91b96d500acc10b2330e25da358.1570553345.git.vladimir.medvedkin@intel.com>
To: test-report@dpdk.org
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Message-Id: <20191008165638.ED0A01E53E@dpdk.org>
Date: Tue,  8 Oct 2019 18:56:38 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw60717 [PATCH v4 5/5] app: add
	test-sad application
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/60717

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#113: FILE: app/test-sad/main.c:24:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {		\
+	unsigned long val;					\
+	char *end_fld;						\
+	errno = 0;						\
+	val = strtoul((in), &end_fld, (base));			\
+	if (errno != 0 || end_fld[0] != (dlm) || val > (lim))	\
+		return -EINVAL;					\
+	(fd) = (typeof(fd))val;					\
+	(in) = end_fld + 1;					\
+} while (0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#321: FILE: app/test-sad/main.c:232:
+	unsigned i, j, rnd;

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'lookup', this function's name, in a string
#612: FILE: app/test-sad/main.c:523:
+	printf("Average lookup cycles %.2Lf, lookups/sec: %.2Lf
",

total: 0 errors, 3 warnings, 684 lines checked