* [dpdk-test-report] |WARNING| pw61041 [PATCH v1 6/6] crypto/ccp: fix for scheduling multiple CCP within single burst ccp driver was scheduling only one CCP in a
[not found] <20191014052202.12625-1-asomalap@amd.com>
@ 2019-10-15 15:44 ` checkpatch
2019-10-29 3:03 ` [dpdk-test-report] |WARNING| pw61041 crypto/ccp: fix for scheduling multiple CCP within single burst ccp driver was scheduling only one CCP in a single burst. Effective throughput was limited to 1 CCP performance. Scheduling multiple ccp within one burst will increase the c 0-day Robot
1 sibling, 0 replies; 2+ messages in thread
From: checkpatch @ 2019-10-15 15:44 UTC (permalink / raw)
To: test-report; +Cc: asomalap
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/61041
_coding style issues_
ERROR:SPACING: space required before the open parenthesis '('
#114: FILE: drivers/crypto/ccp/ccp_crypto.c:3079:
+ } else if(b_info->tail_offset != b_info->head_offset) {
ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#174: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:26:
+uint8_t cryptodev_cnt = 0;
ERROR:SPACING: space required after that ',' (ctx:VxV)
#182: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:206:
+ uint16_t tmp_ops = nb_ops,b_idx,cur_ops=0;
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#182: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:206:
+ uint16_t tmp_ops = nb_ops,b_idx,cur_ops=0;
^
ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#182: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:206:
+ uint16_t tmp_ops = nb_ops,b_idx,cur_ops=0;
^
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#189: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:213:
+ if(tmp_ops >= cryptodev_cnt)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#189: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:213:
+ if(tmp_ops >= cryptodev_cnt)
ERROR:SPACING: need consistent spacing around '+' (ctx:VxW)
#191: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:215:
+ cur_ops = nb_ops / cryptodev_cnt+ (nb_ops)%cryptodev_cnt ;
^
WARNING:SPACING: space prohibited before semicolon
#191: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:215:
+ cur_ops = nb_ops / cryptodev_cnt+ (nb_ops)%cryptodev_cnt ;
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#193: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:217:
+ }
+ else
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#195: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:219:
+ while(tmp_ops)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#195: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:219:
+ while(tmp_ops)
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#199: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:223:
+ if(cur_ops <= tmp_ops )
+ {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#199: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:223:
+ if(cur_ops <= tmp_ops )
ERROR:SPACING: space required before the open parenthesis '('
#199: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:223:
+ if(cur_ops <= tmp_ops )
ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:225:
+^I tmp_ops -= cur_ops;$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#203: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:227:
+ else
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#203: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:227:
+ }
+ else
WARNING:LONG_LINE: line over 90 characters
#232: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:247:
+ enq_cnt += process_ops_to_enqueue(qp, ops, cmd_q, cur_ops, nb_ops, slots_req, b_idx);
ERROR:SPACING: space required after that ',' (ctx:VxO)
#251: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:261:
+ nb_dequeued = process_ops_to_dequeue(qp, ops, nb_ops,&total_nb_ops);
^
ERROR:SPACING: space required before that '&' (ctx:OxV)
#251: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:261:
+ nb_dequeued = process_ops_to_dequeue(qp, ops, nb_ops,&total_nb_ops);
^
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#254: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:263:
+ if(total_nb_ops)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#254: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:263:
+ if(total_nb_ops)
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#256: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:265:
+ while(nb_dequeued != total_nb_ops)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#256: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:265:
+ while(nb_dequeued != total_nb_ops)
WARNING:LONG_LINE: line over 90 characters
#258: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:267:
+ nb_dequeued = process_ops_to_dequeue(qp, ops, nb_ops,&total_nb_ops);
ERROR:SPACING: space required after that ',' (ctx:VxO)
#258: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:267:
+ nb_dequeued = process_ops_to_dequeue(qp, ops, nb_ops,&total_nb_ops);
^
ERROR:SPACING: space required before that '&' (ctx:OxV)
#258: FILE: drivers/crypto/ccp/rte_ccp_pmd.c:267:
+ nb_dequeued = process_ops_to_dequeue(qp, ops, nb_ops,&total_nb_ops);
^
total: 25 errors, 3 warnings, 202 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread