automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Joyce Kong <joyce.kong@arm.com>
Subject: [dpdk-test-report] |WARNING| pw61188 [PATCH v1 3/5] net/bnx2x: use common rte bit operation APIs instead
Date: Tue, 15 Oct 2019 17:47:40 +0200 (CEST)	[thread overview]
Message-ID: <20191015154740.7242B1ED2A@dpdk.org> (raw)
In-Reply-To: <1571125801-45773-4-git-send-email-joyce.kong@arm.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/61188

_coding style issues_


WARNING:BRACES: braces {} are not necessary for any arm of this statement
#232: FILE: drivers/net/bnx2x/bnx2x.c:1843:
+	if (rte_test_bit(ECORE_FILTER_RX_MODE_PENDING, &sc->sp_state)) {
[...]
 	} else {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#289: FILE: drivers/net/bnx2x/bnx2x.c:4299:
+	if (rte_test_and_clear_bit(ECORE_FILTER_RX_MODE_SCHED, &sc->sp_state)) {
 		bnx2x_set_storm_rx_mode(sc);
 	}

total: 0 errors, 2 warnings, 0 checks, 510 lines checked

           reply	other threads:[~2019-10-15 15:48 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1571125801-45773-4-git-send-email-joyce.kong@arm.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191015154740.7242B1ED2A@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=joyce.kong@arm.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).