From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 04D41A317C
	for <public@inbox.dpdk.org>; Thu, 17 Oct 2019 17:50:16 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id EFCA31E989;
	Thu, 17 Oct 2019 17:50:15 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 0AE9A1E9D6; Thu, 17 Oct 2019 17:50:12 +0200 (CEST)
In-Reply-To: <c4a7e686a7ab8a4b90834e212a44559550b43da9.1571322983.git.vladimir.medvedkin@intel.com>
References: <c4a7e686a7ab8a4b90834e212a44559550b43da9.1571322983.git.vladimir.medvedkin@intel.com>
To: test-report@dpdk.org
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Message-Id: <20191017155012.0AE9A1E9D6@dpdk.org>
Date: Thu, 17 Oct 2019 17:50:12 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw61431 [PATCH v6 5/6] app: add
	test-sad application
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/61431

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#114: FILE: app/test-sad/main.c:24:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {		\
+	unsigned long val;					\
+	char *end_fld;						\
+	errno = 0;						\
+	val = strtoul((in), &end_fld, (base));			\
+	if (errno != 0 || end_fld[0] != (dlm) || val > (lim))	\
+		return -EINVAL;					\
+	(fd) = (typeof(fd))val;					\
+	(in) = end_fld + 1;					\
+} while (0)

WARNING:TYPO_SPELLING: 'availible' may be misspelled - perhaps 'available'?
#240: FILE: app/test-sad/main.c:150:
+		"[-p <parallel lookup on all availible cores>]
"

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#328: FILE: app/test-sad/main.c:238:
+	unsigned i, j, rnd;

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'lookup', this function's name, in a string
#627: FILE: app/test-sad/main.c:537:
+	printf("Average lookup cycles %.2Lf, lookups/sec: %.2Lf
",

total: 0 errors, 4 warnings, 708 lines checked