From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw61934 [PATCH] cmdline: prefix cmdline numeric enum
Date: Thu, 24 Oct 2019 20:10:34 +0200 (CEST) [thread overview]
Message-ID: <20191024181034.AEEF41EC1A@dpdk.org> (raw)
In-Reply-To: <20191024180926.8304-1-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/61934
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#298: FILE: app/test-pmd/cmdline.c:3173:
+ TOKEN_NUM_INITIALIZER(struct cmd_config_dcb, num_tcs, CMDLINE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#298: FILE: app/test-pmd/cmdline.c:3173:
+ TOKEN_NUM_INITIALIZER(struct cmd_config_dcb, num_tcs, CMDLINE_UINT8);$
WARNING:LONG_LINE: line over 90 characters
#701: FILE: app/test-pmd/cmdline.c:6491:
+ TOKEN_NUM_INITIALIZER(struct cmd_set_burst_tx_retry_result, retry_num, CMDLINE_UINT32);
ERROR:CODE_INDENT: code indent should use tabs where possible
#3616: FILE: examples/qos_sched/cmdline.c:116:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3616: FILE: examples/qos_sched/cmdline.c:116:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3625: FILE: examples/qos_sched/cmdline.c:191:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3625: FILE: examples/qos_sched/cmdline.c:191:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3645: FILE: examples/qos_sched/cmdline.c:245:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3645: FILE: examples/qos_sched/cmdline.c:245:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3652: FILE: examples/qos_sched/cmdline.c:251:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3652: FILE: examples/qos_sched/cmdline.c:251:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3668: FILE: examples/qos_sched/cmdline.c:308:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3668: FILE: examples/qos_sched/cmdline.c:308:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3675: FILE: examples/qos_sched/cmdline.c:314:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3675: FILE: examples/qos_sched/cmdline.c:314:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3682: FILE: examples/qos_sched/cmdline.c:320:
+ CMDLINE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3682: FILE: examples/qos_sched/cmdline.c:320:
+ CMDLINE_UINT8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3689: FILE: examples/qos_sched/cmdline.c:326:
+ CMDLINE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3689: FILE: examples/qos_sched/cmdline.c:326:
+ CMDLINE_UINT8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3705: FILE: examples/qos_sched/cmdline.c:385:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3705: FILE: examples/qos_sched/cmdline.c:385:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3712: FILE: examples/qos_sched/cmdline.c:391:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3712: FILE: examples/qos_sched/cmdline.c:391:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3719: FILE: examples/qos_sched/cmdline.c:397:
+ CMDLINE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3719: FILE: examples/qos_sched/cmdline.c:397:
+ CMDLINE_UINT8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3735: FILE: examples/qos_sched/cmdline.c:452:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3735: FILE: examples/qos_sched/cmdline.c:452:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3742: FILE: examples/qos_sched/cmdline.c:458:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3742: FILE: examples/qos_sched/cmdline.c:458:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3758: FILE: examples/qos_sched/cmdline.c:511:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3758: FILE: examples/qos_sched/cmdline.c:511:
+ CMDLINE_UINT32);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3765: FILE: examples/qos_sched/cmdline.c:517:
+ CMDLINE_UINT8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3765: FILE: examples/qos_sched/cmdline.c:517:
+ CMDLINE_UINT8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#3781: FILE: examples/qos_sched/cmdline.c:568:
+ CMDLINE_UINT32);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3781: FILE: examples/qos_sched/cmdline.c:568:
+ CMDLINE_UINT32);$
ERROR:SPACING: space prohibited after that open parenthesis '('
#3887: FILE: lib/librte_cmdline/cmdline_parse_num.c:262:
+ if ( nd.type == CMDLINE_INT8 && res1 <= INT8_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3887: FILE: lib/librte_cmdline/cmdline_parse_num.c:262:
+ if ( nd.type == CMDLINE_INT8 && res1 <= INT8_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3892: FILE: lib/librte_cmdline/cmdline_parse_num.c:266:
+ else if ( nd.type == CMDLINE_INT16 && res1 <= INT16_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3892: FILE: lib/librte_cmdline/cmdline_parse_num.c:266:
+ else if ( nd.type == CMDLINE_INT16 && res1 <= INT16_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3892: FILE: lib/librte_cmdline/cmdline_parse_num.c:266:
}
+ else if ( nd.type == CMDLINE_INT16 && res1 <= INT16_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3897: FILE: lib/librte_cmdline/cmdline_parse_num.c:270:
+ else if ( nd.type == CMDLINE_INT32 && res1 <= INT32_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3897: FILE: lib/librte_cmdline/cmdline_parse_num.c:270:
+ else if ( nd.type == CMDLINE_INT32 && res1 <= INT32_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3897: FILE: lib/librte_cmdline/cmdline_parse_num.c:270:
}
+ else if ( nd.type == CMDLINE_INT32 && res1 <= INT32_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3902: FILE: lib/librte_cmdline/cmdline_parse_num.c:274:
+ else if ( nd.type == CMDLINE_INT64 && res1 <= INT64_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3902: FILE: lib/librte_cmdline/cmdline_parse_num.c:274:
+ else if ( nd.type == CMDLINE_INT64 && res1 <= INT64_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3902: FILE: lib/librte_cmdline/cmdline_parse_num.c:274:
}
+ else if ( nd.type == CMDLINE_INT64 && res1 <= INT64_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3907: FILE: lib/librte_cmdline/cmdline_parse_num.c:278:
+ else if ( nd.type == CMDLINE_UINT8 && res1 <= UINT8_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3907: FILE: lib/librte_cmdline/cmdline_parse_num.c:278:
+ else if ( nd.type == CMDLINE_UINT8 && res1 <= UINT8_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3907: FILE: lib/librte_cmdline/cmdline_parse_num.c:278:
}
+ else if ( nd.type == CMDLINE_UINT8 && res1 <= UINT8_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3912: FILE: lib/librte_cmdline/cmdline_parse_num.c:282:
+ else if (nd.type == CMDLINE_UINT16 && res1 <= UINT16_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3912: FILE: lib/librte_cmdline/cmdline_parse_num.c:282:
}
+ else if (nd.type == CMDLINE_UINT16 && res1 <= UINT16_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3917: FILE: lib/librte_cmdline/cmdline_parse_num.c:286:
+ else if ( nd.type == CMDLINE_UINT32 && res1 <= UINT32_MAX ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3917: FILE: lib/librte_cmdline/cmdline_parse_num.c:286:
+ else if ( nd.type == CMDLINE_UINT32 && res1 <= UINT32_MAX ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3917: FILE: lib/librte_cmdline/cmdline_parse_num.c:286:
}
+ else if ( nd.type == CMDLINE_UINT32 && res1 <= UINT32_MAX ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3922: FILE: lib/librte_cmdline/cmdline_parse_num.c:290:
+ else if ( nd.type == CMDLINE_UINT64 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3922: FILE: lib/librte_cmdline/cmdline_parse_num.c:290:
+ else if ( nd.type == CMDLINE_UINT64 ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3922: FILE: lib/librte_cmdline/cmdline_parse_num.c:290:
}
+ else if ( nd.type == CMDLINE_UINT64 ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3931: FILE: lib/librte_cmdline/cmdline_parse_num.c:300:
+ if ( nd.type == CMDLINE_INT8 && res1 <= INT8_MAX + 1 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3931: FILE: lib/librte_cmdline/cmdline_parse_num.c:300:
+ if ( nd.type == CMDLINE_INT8 && res1 <= INT8_MAX + 1 ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3936: FILE: lib/librte_cmdline/cmdline_parse_num.c:304:
+ else if ( nd.type == CMDLINE_INT16 && res1 <= (uint16_t)INT16_MAX + 1 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3936: FILE: lib/librte_cmdline/cmdline_parse_num.c:304:
+ else if ( nd.type == CMDLINE_INT16 && res1 <= (uint16_t)INT16_MAX + 1 ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3936: FILE: lib/librte_cmdline/cmdline_parse_num.c:304:
}
+ else if ( nd.type == CMDLINE_INT16 && res1 <= (uint16_t)INT16_MAX + 1 ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3941: FILE: lib/librte_cmdline/cmdline_parse_num.c:308:
+ else if ( nd.type == CMDLINE_INT32 && res1 <= (uint32_t)INT32_MAX + 1 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3941: FILE: lib/librte_cmdline/cmdline_parse_num.c:308:
+ else if ( nd.type == CMDLINE_INT32 && res1 <= (uint32_t)INT32_MAX + 1 ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3941: FILE: lib/librte_cmdline/cmdline_parse_num.c:308:
}
+ else if ( nd.type == CMDLINE_INT32 && res1 <= (uint32_t)INT32_MAX + 1 ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#3946: FILE: lib/librte_cmdline/cmdline_parse_num.c:312:
+ else if ( nd.type == CMDLINE_INT64 && res1 <= (uint64_t)INT64_MAX + 1 ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3946: FILE: lib/librte_cmdline/cmdline_parse_num.c:312:
+ else if ( nd.type == CMDLINE_INT64 && res1 <= (uint64_t)INT64_MAX + 1 ) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3946: FILE: lib/librte_cmdline/cmdline_parse_num.c:312:
}
+ else if ( nd.type == CMDLINE_INT64 && res1 <= (uint64_t)INT64_MAX + 1 ) {
total: 50 errors, 18 warnings, 3594 lines checked
next parent reply other threads:[~2019-10-24 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191024180926.8304-1-stephen@networkplumber.org>
2019-10-24 18:10 ` checkpatch [this message]
2019-10-25 16:04 ` [dpdk-test-report] |SUCCESS| pw61934 " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024181034.AEEF41EC1A@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).