From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E47FEA0352
	for <public@inbox.dpdk.org>; Mon,  4 Nov 2019 12:03:19 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id DBDE63576;
	Mon,  4 Nov 2019 12:03:19 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id CACB23977; Mon,  4 Nov 2019 12:03:18 +0100 (CET)
In-Reply-To: <1572598450-245091-3-git-send-email-jiayu.hu@intel.com>
References: <1572598450-245091-3-git-send-email-jiayu.hu@intel.com>
To: test-report@dpdk.org
Cc: Jiayu Hu <jiayu.hu@intel.com>
Message-Id: <20191104110318.CACB23977@dpdk.org>
Date: Mon,  4 Nov 2019 12:03:18 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw62299 [RFC v2 2/2] net/vhost_dma:
	add vHost DMA driver
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/62299

_coding style issues_


WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#240: FILE: drivers/net/vhost_dma/eth_vhost.c:33:
+static const char *valid_arguments[] = {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#855: FILE: drivers/net/vhost_dma/eth_vhost.c:648:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#918: FILE: drivers/net/vhost_dma/eth_vhost.c:711:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1186: FILE: drivers/net/vhost_dma/eth_vhost.c:979:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1227: FILE: drivers/net/vhost_dma/eth_vhost.c:1020:
+	unsigned i;

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vr' - possible side-effects?
#1755: FILE: drivers/net/vhost_dma/eth_vhost.h:47:
+#define vhost_avail_event(vr) \
+	(*(volatile uint16_t*)&(vr)->used->ring[(vr)->size])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vr' - possible side-effects?
#1757: FILE: drivers/net/vhost_dma/eth_vhost.h:49:
+#define vhost_used_event(vr) \
+	(*(volatile uint16_t*)&(vr)->avail->ring[(vr)->size])

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0'
#2268: FILE: drivers/net/vhost_dma/virtio_net.c:49:
+		if ((vhost_need_event(vhost_used_event(vr), new, old) &&
+		     (vr->callfd >= 0)) || unlikely(!signalled_used_valid))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0'
#2272: FILE: drivers/net/vhost_dma/virtio_net.c:53:
+		if (!(vr->avail->flags & VRING_AVAIL_F_NO_INTERRUPT) &&
+		    (vr->callfd >= 0))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects?
#2430: FILE: drivers/net/vhost_dma/virtio_net.c:211:
+#define ASSIGN_UNLESS_EQUAL(var, val) do {	\
+	if ((var) != (val))			\
+		(var) = (val);			\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#2430: FILE: drivers/net/vhost_dma/virtio_net.c:211:
+#define ASSIGN_UNLESS_EQUAL(var, val) do {	\
+	if ((var) != (val))			\
+		(var) = (val);			\
+} while (0)

total: 0 errors, 5 warnings, 3290 lines checked