From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 424ACA04F5
	for <public@inbox.dpdk.org>; Wed, 11 Dec 2019 19:46:00 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2A63491;
	Wed, 11 Dec 2019 19:46:00 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id 2E23F34EF; Wed, 11 Dec 2019 19:45:59 +0100 (CET)
In-Reply-To: <47c912c650adf1461634807af1ad086841e19187.1576089843.git.vladimir.medvedkin@intel.com>
References: <47c912c650adf1461634807af1ad086841e19187.1576089843.git.vladimir.medvedkin@intel.com>
To: test-report@dpdk.org
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Message-Id: <20191211184559.2E23F34EF@dpdk.org>
Date: Wed, 11 Dec 2019 19:45:59 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw63782 [PATCH] app/test-fib: add
	test-fib application
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/63782

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#121: FILE: app/test-fib/main.c:26:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {		\
+	unsigned long val;					\
+	char *end_fld;						\
+	errno = 0;						\
+	val = strtoul((in), &end_fld, (base));			\
+	if (errno != 0 || end_fld[0] != (dlm) || val > (lim))	\
+		return -EINVAL;					\
+	(fd) = (typeof(fd))val;					\
+	(in) = end_fld + 1;					\
+} while (0)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#158: FILE: app/test-fib/main.c:63:
+#define NIPQUAD(addr)				\
+	(unsigned)((unsigned char *)&addr)[3],	\
+	(unsigned)((unsigned char *)&addr)[2],	\
+	(unsigned)((unsigned char *)&addr)[1],	\
+	(unsigned)((unsigned char *)&addr)[0]

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#159: FILE: app/test-fib/main.c:64:
+	(unsigned)((unsigned char *)&addr)[3],	\

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#160: FILE: app/test-fib/main.c:65:
+	(unsigned)((unsigned char *)&addr)[2],	\

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#161: FILE: app/test-fib/main.c:66:
+	(unsigned)((unsigned char *)&addr)[1],	\

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#162: FILE: app/test-fib/main.c:67:
+	(unsigned)((unsigned char *)&addr)[0]

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#165: FILE: app/test-fib/main.c:70:
+#define NIPQUAD6(addr)				\
+	((uint8_t *)addr)[0] << 8 |	\
+	((uint8_t *)addr)[1],		\
+	((uint8_t *)addr)[2] << 8 |	\
+	((uint8_t *)addr)[3],		\
+	((uint8_t *)addr)[4] << 8 |	\
+	((uint8_t *)addr)[5],		\
+	((uint8_t *)addr)[6] << 8 |	\
+	((uint8_t *)addr)[7],		\
+	((uint8_t *)addr)[8] << 8 |	\
+	((uint8_t *)addr)[9],		\
+	((uint8_t *)addr)[10] << 8 |	\
+	((uint8_t *)addr)[11],		\
+	((uint8_t *)addr)[12] << 8 |	\
+	((uint8_t *)addr)[13],		\
+	((uint8_t *)addr)[14] << 8 |	\
+	((uint8_t *)addr)[15]

total: 2 errors, 5 warnings, 1289 lines checked