From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Michal Krawczyk <mk@semihalf.com>
Subject: [dpdk-test-report] |WARNING| pw63837 [PATCH 1/2] net/ena: upgrade HAL for new HW features
Date: Fri, 13 Dec 2019 14:33:30 +0100 (CET) [thread overview]
Message-ID: <20191213133330.1C6E11BF80@dpdk.org> (raw)
In-Reply-To: <20191213133216.23572-2-mk@semihalf.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/63837
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#365: FILE: drivers/net/ena/base/ena_com.c:750:
+ comp_ctx->cmd_opcode, admin_queue->auto_polling ? "ON" : "OFF");
WARNING:LONG_LINE_COMMENT: line over 90 characters
#379: FILE: drivers/net/ena/base/ena_com.c:760:
+ * and autopolling mode is enabled. Continuing normal execution in such case
WARNING:LONG_LINE: line over 90 characters
#406: FILE: drivers/net/ena/base/ena_com.c:924:
+ (io_sq->llq_info.desc_list_entry_size * ENA_COM_BOUNCE_BUFFER_CNTRL_CNT));
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#436: FILE: drivers/net/ena/base/ena_com.c:1685:
+bool ena_com_get_admin_polling_mode(struct ena_com_dev * ena_dev)
WARNING:LONG_LINE: line over 90 characters
#504: FILE: drivers/net/ena/base/ena_com.c:2924:
+ (sizeof(struct ena_intr_moder_entry) * ENA_INTR_MAX_NUM_OF_LEVELS));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around ena_dev->llq_info
#524: FILE: drivers/net/ena/base/ena_com.c:3069:
+ struct ena_com_llq_info *llq_info = &(ena_dev->llq_info);;
WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
#524: FILE: drivers/net/ena/base/ena_com.c:3069:
+ struct ena_com_llq_info *llq_info = &(ena_dev->llq_info);;
WARNING:LONG_LINE: line over 90 characters
#698: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1552:
+static inline uint32_t get_ena_admin_host_info_mutable_rss_table_size(const struct ena_admin_host_info *p)
WARNING:LONG_LINE: line over 90 characters
#700: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1554:
+ return p->driver_supported_features & ENA_ADMIN_HOST_INFO_MUTABLE_RSS_TABLE_SIZE_MASK;
WARNING:LONG_LINE: line over 90 characters
#703: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1557:
+static inline void set_ena_admin_host_info_mutable_rss_table_size(struct ena_admin_host_info *p, uint32_t val)
WARNING:LONG_LINE: line over 90 characters
#705: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1559:
+ p->driver_supported_features |= val & ENA_ADMIN_HOST_INFO_MUTABLE_RSS_TABLE_SIZE_MASK;
WARNING:LONG_LINE: line over 90 characters
#708: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1562:
+static inline uint32_t get_ena_admin_host_info_rx_offset(const struct ena_admin_host_info *p)
WARNING:LONG_LINE: line over 90 characters
#710: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1564:
+ return (p->driver_supported_features & ENA_ADMIN_HOST_INFO_RX_OFFSET_MASK) >> ENA_ADMIN_HOST_INFO_RX_OFFSET_SHIFT;
WARNING:LONG_LINE: line over 90 characters
#713: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1567:
+static inline void set_ena_admin_host_info_rx_offset(struct ena_admin_host_info *p, uint32_t val)
WARNING:LONG_LINE: line over 90 characters
#715: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1569:
+ p->driver_supported_features |= (val << ENA_ADMIN_HOST_INFO_RX_OFFSET_SHIFT) & ENA_ADMIN_HOST_INFO_RX_OFFSET_MASK;
WARNING:LONG_LINE: line over 90 characters
#718: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1572:
+static inline uint32_t get_ena_admin_host_info_interrupt_moderation(const struct ena_admin_host_info *p)
WARNING:LONG_LINE: line over 90 characters
#720: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1574:
+ return (p->driver_supported_features & ENA_ADMIN_HOST_INFO_INTERRUPT_MODERATION_MASK) >> ENA_ADMIN_HOST_INFO_INTERRUPT_MODERATION_SHIFT;
WARNING:LONG_LINE: line over 90 characters
#723: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1577:
+static inline void set_ena_admin_host_info_interrupt_moderation(struct ena_admin_host_info *p, uint32_t val)
WARNING:LONG_LINE: line over 90 characters
#725: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1579:
+ p->driver_supported_features |= (val << ENA_ADMIN_HOST_INFO_INTERRUPT_MODERATION_SHIFT) & ENA_ADMIN_HOST_INFO_INTERRUPT_MODERATION_MASK;
WARNING:LONG_LINE: line over 90 characters
#728: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1582:
+static inline uint32_t get_ena_admin_host_info_map_rx_buf_bidirectional(const struct ena_admin_host_info *p)
WARNING:LONG_LINE: line over 90 characters
#730: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1584:
+ return (p->driver_supported_features & ENA_ADMIN_HOST_INFO_MAP_RX_BUF_BIDIRECTIONAL_MASK) >> ENA_ADMIN_HOST_INFO_MAP_RX_BUF_BIDIRECTIONAL_SHIFT;
WARNING:LONG_LINE: line over 90 characters
#733: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1587:
+static inline void set_ena_admin_host_info_map_rx_buf_bidirectional(struct ena_admin_host_info *p, uint32_t val)
WARNING:LONG_LINE: line over 90 characters
#735: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1589:
+ p->driver_supported_features |= (val << ENA_ADMIN_HOST_INFO_MAP_RX_BUF_BIDIRECTIONAL_SHIFT) & ENA_ADMIN_HOST_INFO_MAP_RX_BUF_BIDIRECTIONAL_MASK;
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#837: FILE: drivers/net/ena/base/ena_eth_com.c:8:
+static struct ena_eth_io_rx_cdesc_base *ena_com_get_next_rx_cdesc(
WARNING:LONG_LINE: line over 90 characters
#947: FILE: drivers/net/ena/base/ena_eth_com.c:191:
+ if (unlikely(llq_info->desc_stride_ctrl == ENA_ADMIN_SINGLE_DESC_PER_ENTRY))
WARNING:LONG_LINE: line over 90 characters
#1094: FILE: drivers/net/ena/base/ena_eth_com.c:527:
+ } while ((++i < nb_hw_desc) && (cdesc = ena_com_rx_cdesc_idx_to_ptr(io_cq, cdesc_idx + i)));
total: 1 errors, 23 warnings, 2 checks, 1082 lines checked
parent reply other threads:[~2019-12-13 13:33 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20191213133216.23572-2-mk@semihalf.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213133330.1C6E11BF80@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=mk@semihalf.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).