From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BE684A04F3
	for <public@inbox.dpdk.org>; Thu,  2 Jan 2020 18:50:18 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 683AF1C198;
	Thu,  2 Jan 2020 18:50:18 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id CB9D61C1D8; Thu,  2 Jan 2020 18:50:17 +0100 (CET)
In-Reply-To: <20200102174838.12908-8-dharmik.thakkar@arm.com>
References: <20200102174838.12908-8-dharmik.thakkar@arm.com>
To: test-report@dpdk.org
Cc: Dharmik Thakkar <dharmik.thakkar@arm.com>
Message-Id: <20200102175017.CB9D61C1D8@dpdk.org>
Date: Thu,  2 Jan 2020 18:50:17 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw64174 [PATCH v2 7/7] net/qede:
	remove 'typedef int bool'
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/64174

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p_iov->b_pre_fp_hsi == true'
#98: FILE: drivers/net/qede/base/ecore_vf.c:449:
+	if (((p_iov->b_pre_fp_hsi == true) &
 	    ETH_HSI_VER_MINOR) &&
 	    (resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR'
#98: FILE: drivers/net/qede/base/ecore_vf.c:449:
+	if (((p_iov->b_pre_fp_hsi == true) &
 	    ETH_HSI_VER_MINOR) &&
 	    (resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR))

CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#98: FILE: drivers/net/qede/base/ecore_vf.c:449:
+	if (((p_iov->b_pre_fp_hsi == true) &

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'qdev->enable_tx_switching == false'
#111: FILE: drivers/net/qede/qede_ethdev.c:453:
+	if ((qdev->enable_tx_switching == false) && (flg == true)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'flg == true'
#111: FILE: drivers/net/qede/qede_ethdev.c:453:
+	if ((qdev->enable_tx_switching == false) && (flg == true)) {

CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#111: FILE: drivers/net/qede/qede_ethdev.c:453:
+	if ((qdev->enable_tx_switching == false) && (flg == true)) {

total: 0 errors, 0 warnings, 6 checks, 33 lines checked