From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Dharmik Thakkar <dharmik.thakkar@arm.com>
Subject: [dpdk-test-report] |WARNING| pw64436 [PATCH v3 7/7] net/qede: remove 'typedef int bool'
Date: Fri, 10 Jan 2020 21:54:11 +0100 (CET) [thread overview]
Message-ID: <20200110205411.8E83E1EBBB@dpdk.org> (raw)
In-Reply-To: <20200110205152.30966-8-dharmik.thakkar@arm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/64436
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p_iov->b_pre_fp_hsi == true'
#100: FILE: drivers/net/qede/base/ecore_vf.c:449:
+ if (((p_iov->b_pre_fp_hsi == true) &
ETH_HSI_VER_MINOR) &&
(resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR'
#100: FILE: drivers/net/qede/base/ecore_vf.c:449:
+ if (((p_iov->b_pre_fp_hsi == true) &
ETH_HSI_VER_MINOR) &&
(resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR))
CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#100: FILE: drivers/net/qede/base/ecore_vf.c:449:
+ if (((p_iov->b_pre_fp_hsi == true) &
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'qdev->enable_tx_switching == false'
#113: FILE: drivers/net/qede/qede_ethdev.c:453:
+ if ((qdev->enable_tx_switching == false) && (flg == true)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'flg == true'
#113: FILE: drivers/net/qede/qede_ethdev.c:453:
+ if ((qdev->enable_tx_switching == false) && (flg == true)) {
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#113: FILE: drivers/net/qede/qede_ethdev.c:453:
+ if ((qdev->enable_tx_switching == false) && (flg == true)) {
total: 0 errors, 0 warnings, 6 checks, 33 lines checked
parent reply other threads:[~2020-01-10 20:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200110205152.30966-8-dharmik.thakkar@arm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110205411.8E83E1EBBB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).