* [dpdk-test-report] |WARNING| pw64436 [PATCH v3 7/7] net/qede: remove 'typedef int bool'
[not found] <20200110205152.30966-8-dharmik.thakkar@arm.com>
@ 2020-01-10 20:54 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-01-10 20:54 UTC (permalink / raw)
To: test-report; +Cc: Dharmik Thakkar
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/64436
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p_iov->b_pre_fp_hsi == true'
#100: FILE: drivers/net/qede/base/ecore_vf.c:449:
+ if (((p_iov->b_pre_fp_hsi == true) &
ETH_HSI_VER_MINOR) &&
(resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR'
#100: FILE: drivers/net/qede/base/ecore_vf.c:449:
+ if (((p_iov->b_pre_fp_hsi == true) &
ETH_HSI_VER_MINOR) &&
(resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR))
CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#100: FILE: drivers/net/qede/base/ecore_vf.c:449:
+ if (((p_iov->b_pre_fp_hsi == true) &
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'qdev->enable_tx_switching == false'
#113: FILE: drivers/net/qede/qede_ethdev.c:453:
+ if ((qdev->enable_tx_switching == false) && (flg == true)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'flg == true'
#113: FILE: drivers/net/qede/qede_ethdev.c:453:
+ if ((qdev->enable_tx_switching == false) && (flg == true)) {
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#113: FILE: drivers/net/qede/qede_ethdev.c:453:
+ if ((qdev->enable_tx_switching == false) && (flg == true)) {
total: 0 errors, 0 warnings, 6 checks, 33 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-10 20:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200110205152.30966-8-dharmik.thakkar@arm.com>
2020-01-10 20:54 ` [dpdk-test-report] |WARNING| pw64436 [PATCH v3 7/7] net/qede: remove 'typedef int bool' checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).