From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ivan Dyukov <i.dyukov@samsung.com>
Subject: [dpdk-test-report] |WARNING| pw64933 [PATCH 2/2] net/virtio: add link speed devarg
Date: Mon, 20 Jan 2020 15:19:43 +0100 (CET) [thread overview]
Message-ID: <20200120141943.532FC1BE3D@dpdk.org> (raw)
In-Reply-To: <20200120141603.18719-3-i.dyukov@samsung.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/64933
_coding style issues_
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#134: FILE: drivers/net/virtio/virtio_ethdev.c:49:
+static int virtio_dev_devargs_parse(
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#169: FILE: drivers/net/virtio/virtio_ethdev.c:1969:
+static const char *valid_args[] = {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#181: FILE: drivers/net/virtio/virtio_ethdev.c:1986:
+static uint32_t
+virtio_dev_speed_capa_get(uint32_t link_speed) {
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#183: FILE: drivers/net/virtio/virtio_ethdev.c:1988:
+ switch (link_speed) {
+ case ETH_SPEED_NUM_10G:
[...]
+ case ETH_SPEED_NUM_20G:
[...]
+ case ETH_SPEED_NUM_25G:
[...]
+ case ETH_SPEED_NUM_40G:
[...]
+ case ETH_SPEED_NUM_50G:
[...]
+ case ETH_SPEED_NUM_56G:
[...]
+ case ETH_SPEED_NUM_100G:
[...]
+ default:
total: 2 errors, 1 warnings, 1 checks, 168 lines checked
next parent reply other threads:[~2020-01-20 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200120141603.18719-3-i.dyukov@samsung.com>
2020-01-20 14:19 ` checkpatch [this message]
2020-01-20 23:01 ` [dpdk-test-report] |SUCCESS| pw64933 " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120141943.532FC1BE3D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=i.dyukov@samsung.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).