[dpdk-test-report] |WARNING| pw66148 [PATCH] net/bnx2x: add multicast MAC address filtering

automatic DPDK test reports
 help / color / mirror / Atom feed

* [dpdk-test-report] |WARNING| pw66148 [PATCH] net/bnx2x: add multicast MAC address filtering
       [not found] <20200228200451.2128-1-sodey@rbbn.com>
@ 2020-02-28 20:06 ` checkpatch
  2020-03-03 19:50 ` [dpdk-test-report] |WARNING| pw66148 " 0-day Robot
  1 sibling, 0 replies; 2+ messages in thread
From: checkpatch @ 2020-02-28 20:06 UTC (permalink / raw)
  To: test-report; +Cc: Dey, Souvik

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66148

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#136: FILE: drivers/net/bnx2x/bnx2x.h:1381:
+    uint16_t mc_addrs_num; /* Multicast mac addresses number */$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#149: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:243:
+	if (IS_VF(sc)) {
+        bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#149: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:243:
+	if (IS_VF(sc)) {
+        bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num);
+    }

ERROR:CODE_INDENT: code indent should use tabs where possible
#150: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:244:
+        bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#150: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:244:
+        bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:245:
+    }$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#161: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:275:
+	 * Number is set to 0 denoting DEL_CMD */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#162: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:276:
+	if (IS_VF(sc)) {
+        bnx2x_vfpf_set_mcast(sc, NULL, 0);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#162: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:276:
+	if (IS_VF(sc)) {
+        bnx2x_vfpf_set_mcast(sc, NULL, 0);
+    }

ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:277:
+        bnx2x_vfpf_set_mcast(sc, NULL, 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:277:
+        bnx2x_vfpf_set_mcast(sc, NULL, 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:278:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#176: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:366:
+    struct bnx2x_softc *sc = dev->data->dev_private;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#177: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:367:
+    int err;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:368:
+    PMD_INIT_FUNC_TRACE(sc);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#180: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:370:
+    err = bnx2x_vfpf_set_mcast(sc, NULL, 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#181: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:371:
+    if (err)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#182: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:372:
+        return err;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#182: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:372:
+        return err;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:373:
+    sc->mc_addrs_num = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:376:
+    err = bnx2x_vfpf_set_mcast(sc, mc_addrs, mc_addrs_num );$

ERROR:SPACING: space prohibited before that close parenthesis ')'
#186: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:376:
+    err = bnx2x_vfpf_set_mcast(sc, mc_addrs, mc_addrs_num );

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#187: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:377:
+    if (err)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#188: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:378:
+        return err;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#188: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:378:
+        return err;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:380:
+    sc->mc_addrs_num = mc_addrs_num;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#191: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:381:
+    memcpy(sc->mc_addrs, mc_addrs, mc_addrs_num * sizeof(*mc_addrs));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#193: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:383:
+    return 0;$

WARNING:LONG_LINE: line over 90 characters
#219: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:709:
+					struct rte_ether_addr *mc_addrs, uint32_t mc_addrs_num)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#221: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:711:
+    struct vf_set_q_filters_tlv *query;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#222: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:712:
+    struct vf_common_reply_tlv *reply = &sc->vf2pf_mbox->resp.common_reply;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#223: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:713:
+    int rc = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:714:
+    uint32_t i = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#225: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:715:
+    query = &sc->vf2pf_mbox->query[0].set_q_filters;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:716:
+    bnx2x_vf_prep(sc, &query->first_tlv, BNX2X_VF_TLV_SET_Q_FILTERS,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#227: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:717:
+                sizeof(*query));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#227: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:717:
+                sizeof(*query));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:719:
+    if (mc_addrs_num > VF_MAX_MULTICAST_PER_VF) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:720:
+        PMD_DRV_LOG(ERR, sc,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:720:
+        PMD_DRV_LOG(ERR, sc,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#234: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:724:
+        rc = -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#234: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:724:
+        rc = -EINVAL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#235: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:725:
+        goto out;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#235: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:725:
+        goto out;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#236: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:726:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#238: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:728:
+    for (i = 0; i < mc_addrs_num; i++) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#239: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:729:
+        PMD_DRV_LOG(DEBUG, sc, "Adding mcast MAC:%x:%x:%x:%x:%x:%x",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#239: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:729:
+        PMD_DRV_LOG(DEBUG, sc, "Adding mcast MAC:%x:%x:%x:%x:%x:%x",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#240: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:730:
+                mc_addrs[i].addr_bytes[0],$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#240: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:730:
+                mc_addrs[i].addr_bytes[0],$

ERROR:CODE_INDENT: code indent should use tabs where possible
#241: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:731:
+                mc_addrs[i].addr_bytes[1],$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#241: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:731:
+                mc_addrs[i].addr_bytes[1],$

ERROR:CODE_INDENT: code indent should use tabs where possible
#242: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:732:
+                mc_addrs[i].addr_bytes[2],$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#242: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:732:
+                mc_addrs[i].addr_bytes[2],$

ERROR:CODE_INDENT: code indent should use tabs where possible
#243: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:733:
+                mc_addrs[i].addr_bytes[3],$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#243: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:733:
+                mc_addrs[i].addr_bytes[3],$

ERROR:CODE_INDENT: code indent should use tabs where possible
#244: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:734:
+                mc_addrs[i].addr_bytes[4],$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#244: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:734:
+                mc_addrs[i].addr_bytes[4],$

ERROR:CODE_INDENT: code indent should use tabs where possible
#245: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:735:
+                mc_addrs[i].addr_bytes[5]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#245: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:735:
+                mc_addrs[i].addr_bytes[5]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#246: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:736:
+        memcpy(query->multicast[i], mc_addrs[i].addr_bytes, ETH_ALEN);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#246: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:736:
+        memcpy(query->multicast[i], mc_addrs[i].addr_bytes, ETH_ALEN);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#247: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:737:
+        i++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#247: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:737:
+        i++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#248: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:738:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#250: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:740:
+    query->vf_qid = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#251: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:741:
+    query->flags = BNX2X_VF_MULTICAST_CHANGED;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#252: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:742:
+    query->multicast_cnt = i;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#255: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:745:
+    bnx2x_add_tlv(sc, query, query->first_tlv.tl.length,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#256: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:746:
+              BNX2X_VF_TLV_LIST_END,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#256: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:746:
+              BNX2X_VF_TLV_LIST_END,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#257: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:747:
+              sizeof(struct channel_list_end_tlv));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#257: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:747:
+              sizeof(struct channel_list_end_tlv));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#259: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:749:
+    rc = bnx2x_do_req4pf(sc, sc->vf2pf_mbox_mapping.paddr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#260: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:750:
+    if (rc)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#261: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:751:
+        goto out;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#261: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:751:
+        goto out;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:753:
+    if (reply->status != BNX2X_VF_STATUS_SUCCESS) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#264: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:754:
+        PMD_DRV_LOG(ERR, sc, "Set Rx mode/multicast failed: %d",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#264: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:754:
+        PMD_DRV_LOG(ERR, sc, "Set Rx mode/multicast failed: %d",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#265: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:755:
+                reply->status);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#265: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:755:
+                reply->status);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#266: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:756:
+        rc = -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#266: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:756:
+        rc = -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#267: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:757:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#270: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:760:
+    bnx2x_vf_finalize(sc, &query->first_tlv);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#272: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:762:
+    return rc;$

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#274: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:764:
+
+}

total: 24 errors, 63 warnings, 1 checks, 139 lines checked

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dpdk-test-report] |WARNING| pw66148 net/bnx2x: add multicast MAC address filtering
       [not found] <20200228200451.2128-1-sodey@rbbn.com>
  2020-02-28 20:06 ` [dpdk-test-report] |WARNING| pw66148 [PATCH] net/bnx2x: add multicast MAC address filtering checkpatch
@ 2020-03-03 19:50 ` 0-day Robot
  1 sibling, 0 replies; 2+ messages in thread
From: 0-day Robot @ 2020-03-03 19:50 UTC (permalink / raw)
  To: test-report; +Cc: sodey, robot

From: robot@bytheb.org

Test-Label: travis-robot
Test-Status: WARNING
http://dpdk.org/patch/66148

_Travis build: failed_
Build URL: https://travis-ci.com/ovsrobot/dpdk/builds/151126699

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-03 19:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200228200451.2128-1-sodey@rbbn.com>
2020-02-28 20:06 ` [dpdk-test-report] |WARNING| pw66148 [PATCH] net/bnx2x: add multicast MAC address filtering checkpatch
2020-03-03 19:50 ` [dpdk-test-report] |WARNING| pw66148 " 0-day Robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).