From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: alvinx.zhang@intel.com
Subject: [dpdk-test-report] |WARNING| pw66395 [PATCH v1 02/15] net/igc: update base share codes
Date: Mon, 9 Mar 2020 09:59:37 +0100 (CET) [thread overview]
Message-ID: <20200309085937.463931C01F@dpdk.org> (raw)
In-Reply-To: <1583742247-370386-2-git-send-email-alvinx.zhang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66395
_coding style issues_
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#498: FILE: drivers/net/igc/base/e1000_82575.h:351:
+void igc_vfta_set_vf(struct igc_hw *, u16, bool);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#498: FILE: drivers/net/igc/base/e1000_82575.h:351:
+void igc_vfta_set_vf(struct igc_hw *, u16, bool);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#498: FILE: drivers/net/igc/base/e1000_82575.h:351:
+void igc_vfta_set_vf(struct igc_hw *, u16, bool);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#499: FILE: drivers/net/igc/base/e1000_82575.h:352:
+void igc_rlpml_set_vf(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#499: FILE: drivers/net/igc/base/e1000_82575.h:352:
+void igc_rlpml_set_vf(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#500: FILE: drivers/net/igc/base/e1000_82575.h:353:
+s32 igc_promisc_set_vf(struct igc_hw *, enum igc_promisc_type type);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#506: FILE: drivers/net/igc/base/e1000_82575.h:359:
+s32 igc_get_eee_status_i354(struct igc_hw *, bool *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool *' should also have an identifier name
#506: FILE: drivers/net/igc/base/e1000_82575.h:359:
+s32 igc_get_eee_status_i354(struct igc_hw *, bool *);
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#608: FILE: drivers/net/igc/base/e1000_api.c:92:
+{
+
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#649: FILE: drivers/net/igc/base/e1000_api.c:133:
+
+}
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2379: FILE: drivers/net/igc/base/e1000_api.h:10:
+extern void igc_init_function_pointers_82542(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2380: FILE: drivers/net/igc/base/e1000_api.h:11:
+extern void igc_init_function_pointers_82543(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2381: FILE: drivers/net/igc/base/e1000_api.h:12:
+extern void igc_init_function_pointers_82540(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2382: FILE: drivers/net/igc/base/e1000_api.h:13:
+extern void igc_init_function_pointers_82571(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2383: FILE: drivers/net/igc/base/e1000_api.h:14:
+extern void igc_init_function_pointers_82541(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2384: FILE: drivers/net/igc/base/e1000_api.h:15:
+extern void igc_init_function_pointers_80003es2lan(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2385: FILE: drivers/net/igc/base/e1000_api.h:16:
+extern void igc_init_function_pointers_ich8lan(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2386: FILE: drivers/net/igc/base/e1000_api.h:17:
+extern void igc_init_function_pointers_82575(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2387: FILE: drivers/net/igc/base/e1000_api.h:18:
+extern void igc_init_function_pointers_vf(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2388: FILE: drivers/net/igc/base/e1000_api.h:19:
+extern void igc_power_up_fiber_serdes_link(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2389: FILE: drivers/net/igc/base/e1000_api.h:20:
+extern void igc_shutdown_fiber_serdes_link(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2390: FILE: drivers/net/igc/base/e1000_api.h:21:
+extern void igc_init_function_pointers_i210(struct igc_hw *hw);
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2391: FILE: drivers/net/igc/base/e1000_api.h:22:
+extern void igc_init_function_pointers_i225(struct igc_hw *hw);
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'length' - possible side-effects?
#2513: FILE: drivers/net/igc/base/e1000_api.h:144:
+#define TBI_ACCEPT(a, status, errors, length, last_byte, \
+ min_frame_size, max_frame_size) \
+ (igc_tbi_sbp_enabled_82543(a) && \
+ (((errors) & IGC_RXD_ERR_FRAME_ERR_MASK) == IGC_RXD_ERR_CE) && \
+ ((last_byte) == CARRIER_EXTENSION) && \
+ (((status) & IGC_RXD_STAT_VP) ? \
+ (((length) > ((min_frame_size) - VLAN_TAG_SIZE)) && \
+ ((length) <= ((max_frame_size) + 1))) : \
+ (((length) > (min_frame_size)) && \
+ ((length) <= ((max_frame_size) + VLAN_TAG_SIZE + 1)))))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'min_frame_size' - possible side-effects?
#2513: FILE: drivers/net/igc/base/e1000_api.h:144:
+#define TBI_ACCEPT(a, status, errors, length, last_byte, \
+ min_frame_size, max_frame_size) \
+ (igc_tbi_sbp_enabled_82543(a) && \
+ (((errors) & IGC_RXD_ERR_FRAME_ERR_MASK) == IGC_RXD_ERR_CE) && \
+ ((last_byte) == CARRIER_EXTENSION) && \
+ (((status) & IGC_RXD_STAT_VP) ? \
+ (((length) > ((min_frame_size) - VLAN_TAG_SIZE)) && \
+ ((length) <= ((max_frame_size) + 1))) : \
+ (((length) > (min_frame_size)) && \
+ ((length) <= ((max_frame_size) + VLAN_TAG_SIZE + 1)))))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'max_frame_size' - possible side-effects?
#2513: FILE: drivers/net/igc/base/e1000_api.h:144:
+#define TBI_ACCEPT(a, status, errors, length, last_byte, \
+ min_frame_size, max_frame_size) \
+ (igc_tbi_sbp_enabled_82543(a) && \
+ (((errors) & IGC_RXD_ERR_FRAME_ERR_MASK) == IGC_RXD_ERR_CE) && \
+ ((last_byte) == CARRIER_EXTENSION) && \
+ (((status) & IGC_RXD_STAT_VP) ? \
+ (((length) > ((min_frame_size) - VLAN_TAG_SIZE)) && \
+ ((length) <= ((max_frame_size) + 1))) : \
+ (((length) > (min_frame_size)) && \
+ ((length) <= ((max_frame_size) + VLAN_TAG_SIZE + 1)))))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#2524: FILE: drivers/net/igc/base/e1000_api.h:155:
+#define IGC_MAX(a, b) ((a) > (b) ? (a) : (b))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#2524: FILE: drivers/net/igc/base/e1000_api.h:155:
+#define IGC_MAX(a, b) ((a) > (b) ? (a) : (b))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#2525: FILE: drivers/net/igc/base/e1000_api.h:156:
+#define IGC_DIVIDE_ROUND_UP(a, b) (((a) + (b) - 1) / (b)) /* ceil(a/b) */
WARNING:RETURN_VOID: void function return statements are not generally useful
#2646: FILE: drivers/net/igc/base/e1000_base.c:114:
+ return;
+}
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#2741: FILE: drivers/net/igc/base/e1000_base.h:11:
+extern void igc_rx_fifo_flush_base(struct igc_hw *hw);
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#4072: FILE: drivers/net/igc/base/e1000_defines.h:1209:
+#define NVM_82580_LAN_FUNC_OFFSET(a) ((a) ? (0x40 + (0x40 * (a))) : 0)
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5199: FILE: drivers/net/igc/base/e1000_hw.h:686:
+ s32 (*init_params)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5200: FILE: drivers/net/igc/base/e1000_hw.h:687:
+ s32 (*id_led_init)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5201: FILE: drivers/net/igc/base/e1000_hw.h:688:
+ s32 (*blink_led)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5202: FILE: drivers/net/igc/base/e1000_hw.h:689:
+ bool (*check_mng_mode)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5203: FILE: drivers/net/igc/base/e1000_hw.h:690:
+ s32 (*check_for_link)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5204: FILE: drivers/net/igc/base/e1000_hw.h:691:
+ s32 (*cleanup_led)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5205: FILE: drivers/net/igc/base/e1000_hw.h:692:
+ void (*clear_hw_cntrs)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5206: FILE: drivers/net/igc/base/e1000_hw.h:693:
+ void (*clear_vfta)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5207: FILE: drivers/net/igc/base/e1000_hw.h:694:
+ s32 (*get_bus_info)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5208: FILE: drivers/net/igc/base/e1000_hw.h:695:
+ void (*set_lan_id)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5209: FILE: drivers/net/igc/base/e1000_hw.h:696:
+ s32 (*get_link_up_info)(struct igc_hw *, u16 *, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#5209: FILE: drivers/net/igc/base/e1000_hw.h:696:
+ s32 (*get_link_up_info)(struct igc_hw *, u16 *, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#5209: FILE: drivers/net/igc/base/e1000_hw.h:696:
+ s32 (*get_link_up_info)(struct igc_hw *, u16 *, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5210: FILE: drivers/net/igc/base/e1000_hw.h:697:
+ s32 (*led_on)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5211: FILE: drivers/net/igc/base/e1000_hw.h:698:
+ s32 (*led_off)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5212: FILE: drivers/net/igc/base/e1000_hw.h:699:
+ void (*update_mc_addr_list)(struct igc_hw *, u8 *, u32);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#5212: FILE: drivers/net/igc/base/e1000_hw.h:699:
+ void (*update_mc_addr_list)(struct igc_hw *, u8 *, u32);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5212: FILE: drivers/net/igc/base/e1000_hw.h:699:
+ void (*update_mc_addr_list)(struct igc_hw *, u8 *, u32);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5213: FILE: drivers/net/igc/base/e1000_hw.h:700:
+ s32 (*reset_hw)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5214: FILE: drivers/net/igc/base/e1000_hw.h:701:
+ s32 (*init_hw)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5215: FILE: drivers/net/igc/base/e1000_hw.h:702:
+ void (*shutdown_serdes)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5216: FILE: drivers/net/igc/base/e1000_hw.h:703:
+ void (*power_up_serdes)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5217: FILE: drivers/net/igc/base/e1000_hw.h:704:
+ s32 (*setup_link)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5218: FILE: drivers/net/igc/base/e1000_hw.h:705:
+ s32 (*setup_physical_interface)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5219: FILE: drivers/net/igc/base/e1000_hw.h:706:
+ s32 (*setup_led)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5220: FILE: drivers/net/igc/base/e1000_hw.h:707:
+ void (*write_vfta)(struct igc_hw *, u32, u32);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5220: FILE: drivers/net/igc/base/e1000_hw.h:707:
+ void (*write_vfta)(struct igc_hw *, u32, u32);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5220: FILE: drivers/net/igc/base/e1000_hw.h:707:
+ void (*write_vfta)(struct igc_hw *, u32, u32);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5221: FILE: drivers/net/igc/base/e1000_hw.h:708:
+ void (*config_collision_dist)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5222: FILE: drivers/net/igc/base/e1000_hw.h:709:
+ int (*rar_set)(struct igc_hw *, u8*, u32);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8*' should also have an identifier name
#5222: FILE: drivers/net/igc/base/e1000_hw.h:709:
+ int (*rar_set)(struct igc_hw *, u8*, u32);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5222: FILE: drivers/net/igc/base/e1000_hw.h:709:
+ int (*rar_set)(struct igc_hw *, u8*, u32);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5223: FILE: drivers/net/igc/base/e1000_hw.h:710:
+ s32 (*read_mac_addr)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5224: FILE: drivers/net/igc/base/e1000_hw.h:711:
+ s32 (*validate_mdi_setting)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5225: FILE: drivers/net/igc/base/e1000_hw.h:712:
+ s32 (*acquire_swfw_sync)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5225: FILE: drivers/net/igc/base/e1000_hw.h:712:
+ s32 (*acquire_swfw_sync)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5226: FILE: drivers/net/igc/base/e1000_hw.h:713:
+ void (*release_swfw_sync)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5226: FILE: drivers/net/igc/base/e1000_hw.h:713:
+ void (*release_swfw_sync)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5244: FILE: drivers/net/igc/base/e1000_hw.h:731:
+ s32 (*init_params)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5245: FILE: drivers/net/igc/base/e1000_hw.h:732:
+ s32 (*acquire)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5246: FILE: drivers/net/igc/base/e1000_hw.h:733:
+ s32 (*cfg_on_link_up)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5247: FILE: drivers/net/igc/base/e1000_hw.h:734:
+ s32 (*check_polarity)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5248: FILE: drivers/net/igc/base/e1000_hw.h:735:
+ s32 (*check_reset_block)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5249: FILE: drivers/net/igc/base/e1000_hw.h:736:
+ s32 (*commit)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5250: FILE: drivers/net/igc/base/e1000_hw.h:737:
+ s32 (*force_speed_duplex)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5252: FILE: drivers/net/igc/base/e1000_hw.h:739:
+ s32 (*get_cable_length)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5253: FILE: drivers/net/igc/base/e1000_hw.h:740:
+ s32 (*get_info)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5254: FILE: drivers/net/igc/base/e1000_hw.h:741:
+ s32 (*set_page)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5254: FILE: drivers/net/igc/base/e1000_hw.h:741:
+ s32 (*set_page)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5255: FILE: drivers/net/igc/base/e1000_hw.h:742:
+ s32 (*read_reg)(struct igc_hw *, u32, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5255: FILE: drivers/net/igc/base/e1000_hw.h:742:
+ s32 (*read_reg)(struct igc_hw *, u32, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#5255: FILE: drivers/net/igc/base/e1000_hw.h:742:
+ s32 (*read_reg)(struct igc_hw *, u32, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5256: FILE: drivers/net/igc/base/e1000_hw.h:743:
+ s32 (*read_reg_locked)(struct igc_hw *, u32, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5256: FILE: drivers/net/igc/base/e1000_hw.h:743:
+ s32 (*read_reg_locked)(struct igc_hw *, u32, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#5256: FILE: drivers/net/igc/base/e1000_hw.h:743:
+ s32 (*read_reg_locked)(struct igc_hw *, u32, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5257: FILE: drivers/net/igc/base/e1000_hw.h:744:
+ s32 (*read_reg_page)(struct igc_hw *, u32, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5257: FILE: drivers/net/igc/base/e1000_hw.h:744:
+ s32 (*read_reg_page)(struct igc_hw *, u32, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#5257: FILE: drivers/net/igc/base/e1000_hw.h:744:
+ s32 (*read_reg_page)(struct igc_hw *, u32, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5258: FILE: drivers/net/igc/base/e1000_hw.h:745:
+ void (*release)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5259: FILE: drivers/net/igc/base/e1000_hw.h:746:
+ s32 (*reset)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5260: FILE: drivers/net/igc/base/e1000_hw.h:747:
+ s32 (*set_d0_lplu_state)(struct igc_hw *, bool);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#5260: FILE: drivers/net/igc/base/e1000_hw.h:747:
+ s32 (*set_d0_lplu_state)(struct igc_hw *, bool);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5261: FILE: drivers/net/igc/base/e1000_hw.h:748:
+ s32 (*set_d3_lplu_state)(struct igc_hw *, bool);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#5261: FILE: drivers/net/igc/base/e1000_hw.h:748:
+ s32 (*set_d3_lplu_state)(struct igc_hw *, bool);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5262: FILE: drivers/net/igc/base/e1000_hw.h:749:
+ s32 (*write_reg)(struct igc_hw *, u32, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5262: FILE: drivers/net/igc/base/e1000_hw.h:749:
+ s32 (*write_reg)(struct igc_hw *, u32, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5262: FILE: drivers/net/igc/base/e1000_hw.h:749:
+ s32 (*write_reg)(struct igc_hw *, u32, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5263: FILE: drivers/net/igc/base/e1000_hw.h:750:
+ s32 (*write_reg_locked)(struct igc_hw *, u32, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5263: FILE: drivers/net/igc/base/e1000_hw.h:750:
+ s32 (*write_reg_locked)(struct igc_hw *, u32, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5263: FILE: drivers/net/igc/base/e1000_hw.h:750:
+ s32 (*write_reg_locked)(struct igc_hw *, u32, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5264: FILE: drivers/net/igc/base/e1000_hw.h:751:
+ s32 (*write_reg_page)(struct igc_hw *, u32, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#5264: FILE: drivers/net/igc/base/e1000_hw.h:751:
+ s32 (*write_reg_page)(struct igc_hw *, u32, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5264: FILE: drivers/net/igc/base/e1000_hw.h:751:
+ s32 (*write_reg_page)(struct igc_hw *, u32, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5265: FILE: drivers/net/igc/base/e1000_hw.h:752:
+ void (*power_up)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5266: FILE: drivers/net/igc/base/e1000_hw.h:753:
+ void (*power_down)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5267: FILE: drivers/net/igc/base/e1000_hw.h:754:
+ s32 (*read_i2c_byte)(struct igc_hw *, u8, u8, u8 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#5267: FILE: drivers/net/igc/base/e1000_hw.h:754:
+ s32 (*read_i2c_byte)(struct igc_hw *, u8, u8, u8 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#5267: FILE: drivers/net/igc/base/e1000_hw.h:754:
+ s32 (*read_i2c_byte)(struct igc_hw *, u8, u8, u8 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#5267: FILE: drivers/net/igc/base/e1000_hw.h:754:
+ s32 (*read_i2c_byte)(struct igc_hw *, u8, u8, u8 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5268: FILE: drivers/net/igc/base/e1000_hw.h:755:
+ s32 (*write_i2c_byte)(struct igc_hw *, u8, u8, u8);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#5268: FILE: drivers/net/igc/base/e1000_hw.h:755:
+ s32 (*write_i2c_byte)(struct igc_hw *, u8, u8, u8);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#5268: FILE: drivers/net/igc/base/e1000_hw.h:755:
+ s32 (*write_i2c_byte)(struct igc_hw *, u8, u8, u8);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#5268: FILE: drivers/net/igc/base/e1000_hw.h:755:
+ s32 (*write_i2c_byte)(struct igc_hw *, u8, u8, u8);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5273: FILE: drivers/net/igc/base/e1000_hw.h:760:
+ s32 (*init_params)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5274: FILE: drivers/net/igc/base/e1000_hw.h:761:
+ s32 (*acquire)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5275: FILE: drivers/net/igc/base/e1000_hw.h:762:
+ s32 (*read)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5275: FILE: drivers/net/igc/base/e1000_hw.h:762:
+ s32 (*read)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5275: FILE: drivers/net/igc/base/e1000_hw.h:762:
+ s32 (*read)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#5275: FILE: drivers/net/igc/base/e1000_hw.h:762:
+ s32 (*read)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5276: FILE: drivers/net/igc/base/e1000_hw.h:763:
+ void (*release)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5277: FILE: drivers/net/igc/base/e1000_hw.h:764:
+ void (*reload)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5278: FILE: drivers/net/igc/base/e1000_hw.h:765:
+ s32 (*update)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5279: FILE: drivers/net/igc/base/e1000_hw.h:766:
+ s32 (*valid_led_default)(struct igc_hw *, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#5279: FILE: drivers/net/igc/base/e1000_hw.h:766:
+ s32 (*valid_led_default)(struct igc_hw *, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5280: FILE: drivers/net/igc/base/e1000_hw.h:767:
+ s32 (*validate)(struct igc_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5281: FILE: drivers/net/igc/base/e1000_hw.h:768:
+ s32 (*write)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5281: FILE: drivers/net/igc/base/e1000_hw.h:768:
+ s32 (*write)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5281: FILE: drivers/net/igc/base/e1000_hw.h:768:
+ s32 (*write)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#5281: FILE: drivers/net/igc/base/e1000_hw.h:768:
+ s32 (*write)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5407: FILE: drivers/net/igc/base/e1000_hw.h:894:
+ s32 (*read)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#5407: FILE: drivers/net/igc/base/e1000_hw.h:894:
+ s32 (*read)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5407: FILE: drivers/net/igc/base/e1000_hw.h:894:
+ s32 (*read)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5407: FILE: drivers/net/igc/base/e1000_hw.h:894:
+ s32 (*read)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5408: FILE: drivers/net/igc/base/e1000_hw.h:895:
+ s32 (*write)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#5408: FILE: drivers/net/igc/base/e1000_hw.h:895:
+ s32 (*write)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5408: FILE: drivers/net/igc/base/e1000_hw.h:895:
+ s32 (*write)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5408: FILE: drivers/net/igc/base/e1000_hw.h:895:
+ s32 (*write)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5409: FILE: drivers/net/igc/base/e1000_hw.h:896:
+ s32 (*read_posted)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#5409: FILE: drivers/net/igc/base/e1000_hw.h:896:
+ s32 (*read_posted)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5409: FILE: drivers/net/igc/base/e1000_hw.h:896:
+ s32 (*read_posted)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5409: FILE: drivers/net/igc/base/e1000_hw.h:896:
+ s32 (*read_posted)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5410: FILE: drivers/net/igc/base/e1000_hw.h:897:
+ s32 (*write_posted)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#5410: FILE: drivers/net/igc/base/e1000_hw.h:897:
+ s32 (*write_posted)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5410: FILE: drivers/net/igc/base/e1000_hw.h:897:
+ s32 (*write_posted)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5410: FILE: drivers/net/igc/base/e1000_hw.h:897:
+ s32 (*write_posted)(struct igc_hw *, u32 *, u16, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5411: FILE: drivers/net/igc/base/e1000_hw.h:898:
+ s32 (*check_for_msg)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5411: FILE: drivers/net/igc/base/e1000_hw.h:898:
+ s32 (*check_for_msg)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5412: FILE: drivers/net/igc/base/e1000_hw.h:899:
+ s32 (*check_for_ack)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5412: FILE: drivers/net/igc/base/e1000_hw.h:899:
+ s32 (*check_for_ack)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#5413: FILE: drivers/net/igc/base/e1000_hw.h:900:
+ s32 (*check_for_rst)(struct igc_hw *, u16);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#5413: FILE: drivers/net/igc/base/e1000_hw.h:900:
+ s32 (*check_for_rst)(struct igc_hw *, u16);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#5582: FILE: drivers/net/igc/base/e1000_i225.c:8:
+STATIC s32 igc_init_mac_params_i225(struct igc_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#5583: FILE: drivers/net/igc/base/e1000_i225.c:9:
+STATIC s32 igc_init_phy_params_i225(struct igc_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#5584: FILE: drivers/net/igc/base/e1000_i225.c:10:
+STATIC s32 igc_reset_hw_i225(struct igc_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#5585: FILE: drivers/net/igc/base/e1000_i225.c:11:
+STATIC s32 igc_acquire_nvm_i225(struct igc_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#5586: FILE: drivers/net/igc/base/e1000_i225.c:12:
+STATIC void igc_release_nvm_i225(struct igc_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#5587: FILE: drivers/net/igc/base/e1000_i225.c:13:
+STATIC s32 igc_get_hw_semaphore_i225(struct igc_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#5588: FILE: drivers/net/igc/base/e1000_i225.c:14:
+STATIC s32 __igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words,
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#5590: FILE: drivers/net/igc/base/e1000_i225.c:16:
+STATIC s32 igc_pool_flash_update_done_i225(struct igc_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#5591: FILE: drivers/net/igc/base/e1000_i225.c:17:
+STATIC s32 igc_valid_led_default_i225(struct igc_hw *hw, u16 *data);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size'
#6134: FILE: drivers/net/igc/base/e1000_i225.c:560:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0'
#6134: FILE: drivers/net/igc/base/e1000_i225.c:560:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == 1'
#6200: FILE: drivers/net/igc/base/e1000_i225.c:626:
+ if ((i == 1) && ((*record & IGC_INVM_VER_FIELD_ONE) == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == 1'
#6245: FILE: drivers/net/igc/base/e1000_i225.c:671:
+ if ((i == 1) && ((*record & IGC_INVM_IMGTYPE_FIELD) == 0)) {
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct igc_hw *' should also have an identifier name
#6272: FILE: drivers/net/igc/base/e1000_i225.c:698:
+ s32 (*read_op_ptr)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#6272: FILE: drivers/net/igc/base/e1000_i225.c:698:
+ s32 (*read_op_ptr)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#6272: FILE: drivers/net/igc/base/e1000_i225.c:698:
+ s32 (*read_op_ptr)(struct igc_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#6272: FILE: drivers/net/igc/base/e1000_i225.c:698:
+ s32 (*read_op_ptr)(struct igc_hw *, u16, u16, u16 *);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == igc_media_type_copper'
#6588: FILE: drivers/net/igc/base/e1000_i225.c:1014:
+ if ((hw->phy.media_type == igc_media_type_copper) &&
+ !(hw->dev_spec._i225.eee_disable) &&
+ (speed != SPEED_10)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed != SPEED_10'
#6588: FILE: drivers/net/igc/base/e1000_i225.c:1014:
+ if ((hw->phy.media_type == igc_media_type_copper) &&
+ !(hw->dev_spec._i225.eee_disable) &&
+ (speed != SPEED_10)) {
CHECK:CAMELCASE: Avoid CamelCase: <I217_SxCTRL>
#7354: FILE: drivers/net/igc/base/e1000_ich8lan.h:269:
+#define I217_SxCTRL PHY_REG(BM_PORT_CTRL_PAGE, 28)
CHECK:CAMELCASE: Avoid CamelCase: <I217_SxCTRL_ENABLE_LPI_RESET>
#7355: FILE: drivers/net/igc/base/e1000_ich8lan.h:270:
+#define I217_SxCTRL_ENABLE_LPI_RESET 0x1000
CHECK:SPACING: No space is necessary after a cast
#9594: FILE: drivers/net/igc/base/e1000_manage.c:29:
+ return (u8) (0 - sum);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hdr_csum != csum'
#9707: FILE: drivers/net/igc/base/e1000_manage.c:142:
+ if ((hdr_csum != csum) || (hdr->signature != IGC_IAMT_SIGNATURE)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hdr->signature != IGC_IAMT_SIGNATURE'
#9707: FILE: drivers/net/igc/base/e1000_manage.c:142:
+ if ((hdr_csum != csum) || (hdr->signature != IGC_IAMT_SIGNATURE)) {
CHECK:SPACING: No space is necessary after a cast
#9741: FILE: drivers/net/igc/base/e1000_manage.c:176:
+ *((u32 *) hdr + i));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around hdr.checksum
#9854: FILE: drivers/net/igc/base/e1000_manage.c:289:
+ sizeof(hdr), &(hdr.checksum));
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#10228: FILE: drivers/net/igc/base/e1000_nvm.c:39:
+s32 igc_null_read_nvm(struct igc_hw IGC_UNUSEDARG *hw,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#10230: FILE: drivers/net/igc/base/e1000_nvm.c:41:
+ u16 IGC_UNUSEDARG *c)
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#10241: FILE: drivers/net/igc/base/e1000_nvm.c:52:
+void igc_null_nvm_generic(struct igc_hw IGC_UNUSEDARG *hw)
^
WARNING:RETURN_VOID: void function return statements are not generally useful
#10246: FILE: drivers/net/igc/base/e1000_nvm.c:57:
+ return;
+}
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#10253: FILE: drivers/net/igc/base/e1000_nvm.c:64:
+s32 igc_null_led_default(struct igc_hw IGC_UNUSEDARG *hw,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#10254: FILE: drivers/net/igc/base/e1000_nvm.c:65:
+ u16 IGC_UNUSEDARG *data)
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#10268: FILE: drivers/net/igc/base/e1000_nvm.c:79:
+s32 igc_null_write_nvm(struct igc_hw IGC_UNUSEDARG *hw,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#10270: FILE: drivers/net/igc/base/e1000_nvm.c:81:
+ u16 IGC_UNUSEDARG *c)
^
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#10328: FILE: drivers/net/igc/base/e1000_nvm.c:139:
+ else
+ if (nvm->type == igc_nvm_eeprom_spi)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size'
#10623: FILE: drivers/net/igc/base/e1000_nvm.c:434:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0'
#10623: FILE: drivers/net/igc/base/e1000_nvm.c:434:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nvm->address_bits == 8'
#10639: FILE: drivers/net/igc/base/e1000_nvm.c:450:
+ if ((nvm->address_bits == 8) && (offset >= 128))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= 128'
#10639: FILE: drivers/net/igc/base/e1000_nvm.c:450:
+ if ((nvm->address_bits == 8) && (offset >= 128))
CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#10644: FILE: drivers/net/igc/base/e1000_nvm.c:455:
+ igc_shift_out_eec_bits(hw, (u16)(offset*2), nvm->address_bits);
^
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size'
#10683: FILE: drivers/net/igc/base/e1000_nvm.c:494:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0'
#10683: FILE: drivers/net/igc/base/e1000_nvm.c:494:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size'
#10736: FILE: drivers/net/igc/base/e1000_nvm.c:547:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0'
#10736: FILE: drivers/net/igc/base/e1000_nvm.c:547:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size'
#10784: FILE: drivers/net/igc/base/e1000_nvm.c:595:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0'
#10784: FILE: drivers/net/igc/base/e1000_nvm.c:595:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nvm->address_bits == 8'
#10814: FILE: drivers/net/igc/base/e1000_nvm.c:625:
+ if ((nvm->address_bits == 8) && (offset >= 128))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= 128'
#10814: FILE: drivers/net/igc/base/e1000_nvm.c:625:
+ if ((nvm->address_bits == 8) && (offset >= 128))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size'
#10867: FILE: drivers/net/igc/base/e1000_nvm.c:678:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0'
#10867: FILE: drivers/net/igc/base/e1000_nvm.c:678:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#11339: FILE: drivers/net/igc/base/e1000_nvm.c:1150:
+ hw->mac.perm_addr[i] = (u8)(rar_low >> (i*8));
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#11342: FILE: drivers/net/igc/base/e1000_nvm.c:1153:
+ hw->mac.perm_addr[i+4] = (u8)(rar_high >> (i*8));
^
CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#11342: FILE: drivers/net/igc/base/e1000_nvm.c:1153:
+ hw->mac.perm_addr[i+4] = (u8)(rar_high >> (i*8));
^
CHECK:SPACING: No space is necessary after a cast
#11374: FILE: drivers/net/igc/base/e1000_nvm.c:1185:
+ if (checksum != (u16) NVM_SUM) {
CHECK:SPACING: No space is necessary after a cast
#11406: FILE: drivers/net/igc/base/e1000_nvm.c:1217:
+ checksum = (u16) NVM_SUM - checksum;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#11450: FILE: drivers/net/igc/base/e1000_nvm.c:1261:
+ * used to create the nvm images */
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'comb_offset != 0x0'
#11457: FILE: drivers/net/igc/base/e1000_nvm.c:1268:
+ if ((comb_offset != 0x0) &&
+ (comb_offset != NVM_VER_INVALID)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'comb_offset != NVM_VER_INVALID'
#11457: FILE: drivers/net/igc/base/e1000_nvm.c:1268:
+ if ((comb_offset != 0x0) &&
+ (comb_offset != NVM_VER_INVALID)) {
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#11459: FILE: drivers/net/igc/base/e1000_nvm.c:1270:
+ (comb_offset != NVM_VER_INVALID)) {
+
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'comb_verh != NVM_VER_INVALID'
#11466: FILE: drivers/net/igc/base/e1000_nvm.c:1277:
+ if ((comb_verh && comb_verl) &&
+ ((comb_verh != NVM_VER_INVALID) &&
+ (comb_verl != NVM_VER_INVALID))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'comb_verl != NVM_VER_INVALID'
#11466: FILE: drivers/net/igc/base/e1000_nvm.c:1277:
+ if ((comb_verh && comb_verl) &&
+ ((comb_verh != NVM_VER_INVALID) &&
+ (comb_verl != NVM_VER_INVALID))) {
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#11469: FILE: drivers/net/igc/base/e1000_nvm.c:1280:
+ (comb_verl != NVM_VER_INVALID))) {
+
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#11605: FILE: drivers/net/igc/base/e1000_phy.c:8:
+STATIC s32 igc_access_phy_wakeup_reg_bm(struct igc_hw *hw, u32 offset,
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#11607: FILE: drivers/net/igc/base/e1000_phy.c:10:
+STATIC u32 igc_get_phy_addr_for_hv_page(u32 page);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#11608: FILE: drivers/net/igc/base/e1000_phy.c:11:
+STATIC s32 igc_access_phy_debug_regs_hv(struct igc_hw *hw, u32 offset,
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#11675: FILE: drivers/net/igc/base/e1000_phy.c:78:
+s32 igc_null_set_page(struct igc_hw IGC_UNUSEDARG *hw,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#11689: FILE: drivers/net/igc/base/e1000_phy.c:92:
+s32 igc_null_read_reg(struct igc_hw IGC_UNUSEDARG *hw,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#11690: FILE: drivers/net/igc/base/e1000_phy.c:93:
+ u32 IGC_UNUSEDARG offset, u16 IGC_UNUSEDARG *data)
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#11701: FILE: drivers/net/igc/base/e1000_phy.c:104:
+void igc_null_phy_generic(struct igc_hw IGC_UNUSEDARG *hw)
^
WARNING:RETURN_VOID: void function return statements are not generally useful
#11706: FILE: drivers/net/igc/base/e1000_phy.c:109:
+ return;
+}
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#11713: FILE: drivers/net/igc/base/e1000_phy.c:116:
+s32 igc_null_lplu_state(struct igc_hw IGC_UNUSEDARG *hw,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#11727: FILE: drivers/net/igc/base/e1000_phy.c:130:
+s32 igc_null_write_reg(struct igc_hw IGC_UNUSEDARG *hw,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#11743: FILE: drivers/net/igc/base/e1000_phy.c:146:
+s32 igc_read_i2c_byte_null(struct igc_hw IGC_UNUSEDARG *hw,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#11746: FILE: drivers/net/igc/base/e1000_phy.c:149:
+ u8 IGC_UNUSEDARG *data)
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#11761: FILE: drivers/net/igc/base/e1000_phy.c:164:
+s32 igc_write_i2c_byte_null(struct igc_hw IGC_UNUSEDARG *hw,
^
CHECK:SPACING: No space is necessary after a cast
#11910: FILE: drivers/net/igc/base/e1000_phy.c:313:
+ *data = (u16) mdic;
WARNING:TYPO_SPELLING: 'overwritting' may be misspelled - perhaps 'overwriting'?
#12050: FILE: drivers/net/igc/base/e1000_phy.c:453:
+ /* Prevent overwritting SFP I2C EEPROM which is at A0 address.*/
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.addr == 0'
#12051: FILE: drivers/net/igc/base/e1000_phy.c:454:
+ if ((hw->phy.addr == 0) || (hw->phy.addr > 7)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.addr > 7'
#12051: FILE: drivers/net/igc/base/e1000_phy.c:454:
+ if ((hw->phy.addr == 0) || (hw->phy.addr > 7)) {
CHECK:SPACING: No space is necessary after a cast
#12140: FILE: drivers/net/igc/base/e1000_phy.c:543:
+ *data = (u8) data_local & 0xFF;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->type == igc_phy_m88'
#12769: FILE: drivers/net/igc/base/e1000_phy.c:1172:
+ if ((phy->type == igc_phy_m88) &&
+ (phy->revision < IGC_REVISION_4) &&
+ (phy->id != BMIGC_E_PHY_ID_R2)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->revision < IGC_REVISION_4'
#12769: FILE: drivers/net/igc/base/e1000_phy.c:1172:
+ if ((phy->type == igc_phy_m88) &&
+ (phy->revision < IGC_REVISION_4) &&
+ (phy->id != BMIGC_E_PHY_ID_R2)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->id != BMIGC_E_PHY_ID_R2'
#12769: FILE: drivers/net/igc/base/e1000_phy.c:1172:
+ if ((phy->type == igc_phy_m88) &&
+ (phy->revision < IGC_REVISION_4) &&
+ (phy->id != BMIGC_E_PHY_ID_R2)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->revision == IGC_REVISION_2'
#12782: FILE: drivers/net/igc/base/e1000_phy.c:1185:
+ if ((phy->revision == IGC_REVISION_2) &&
+ (phy->id == M88E1111_I_PHY_ID)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->id == M88E1111_I_PHY_ID'
#12782: FILE: drivers/net/igc/base/e1000_phy.c:1185:
+ if ((phy->revision == IGC_REVISION_2) &&
+ (phy->id == M88E1111_I_PHY_ID)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->type == igc_phy_bm'
#12800: FILE: drivers/net/igc/base/e1000_phy.c:1203:
+ if ((phy->type == igc_phy_bm) && (phy->id == BMIGC_E_PHY_ID_R2)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy->id == BMIGC_E_PHY_ID_R2'
#12800: FILE: drivers/net/igc/base/e1000_phy.c:1203:
+ if ((phy->type == igc_phy_bm) && (phy->id == BMIGC_E_PHY_ID_R2)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.id == M88E1543_E_PHY_ID'
#13527: FILE: drivers/net/igc/base/e1000_phy.c:1930:
+ if ((hw->phy.id == M88E1543_E_PHY_ID) ||
+ (hw->phy.id == M88E1512_E_PHY_ID))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.id == M88E1512_E_PHY_ID'
#13527: FILE: drivers/net/igc/base/e1000_phy.c:1930:
+ if ((hw->phy.id == M88E1543_E_PHY_ID) ||
+ (hw->phy.id == M88E1512_E_PHY_ID))
CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#13990: FILE: drivers/net/igc/base/e1000_phy.c:2393:
+ msec_delay(usec_interval/1000);
^
CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#14000: FILE: drivers/net/igc/base/e1000_phy.c:2403:
+ msec_delay(usec_interval/1000);
^
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_agc_index >= IGP02IGC_CABLE_LENGTH_TABLE_SIZE'
#14210: FILE: drivers/net/igc/base/e1000_phy.c:2613:
+ if ((cur_agc_index >= IGP02IGC_CABLE_LENGTH_TABLE_SIZE) ||
+ (cur_agc_index == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_agc_index == 0'
#14210: FILE: drivers/net/igc/base/e1000_phy.c:2613:
+ if ((cur_agc_index >= IGP02IGC_CABLE_LENGTH_TABLE_SIZE) ||
+ (cur_agc_index == 0))
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#14515: FILE: drivers/net/igc/base/e1000_phy.c:2918:
+s32 igc_get_cfg_done_generic(struct igc_hw IGC_UNUSEDARG *hw)
^
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'page >= 768'
#14725: FILE: drivers/net/igc/base/e1000_phy.c:3128:
+ if ((page >= 768) || (page == 0 && reg == 25) || (reg == 31))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg == 31'
#14725: FILE: drivers/net/igc/base/e1000_phy.c:3128:
+ if ((page >= 768) || (page == 0 && reg == 25) || (reg == 31))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->mac.type == igc_pchlan'
#15068: FILE: drivers/net/igc/base/e1000_phy.c:3471:
+ if ((hw->mac.type == igc_pchlan) &&
+ (!(IGC_READ_REG(hw, IGC_PHY_CTRL) & IGC_PHY_CTRL_GBE_DISABLE)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.type == igc_phy_82578'
#15305: FILE: drivers/net/igc/base/e1000_phy.c:3708:
+ if ((hw->phy.type == igc_phy_82578) &&
+ (hw->phy.revision >= 1) &&
+ (hw->phy.addr == 2) &&
+ !(MAX_PHY_REG_ADDRESS & reg) &&
+ (data & (1 << 11))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.revision >= 1'
#15305: FILE: drivers/net/igc/base/e1000_phy.c:3708:
+ if ((hw->phy.type == igc_phy_82578) &&
+ (hw->phy.revision >= 1) &&
+ (hw->phy.addr == 2) &&
+ !(MAX_PHY_REG_ADDRESS & reg) &&
+ (data & (1 << 11))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.addr == 2'
#15305: FILE: drivers/net/igc/base/e1000_phy.c:3708:
+ if ((hw->phy.type == igc_phy_82578) &&
+ (hw->phy.revision >= 1) &&
+ (hw->phy.addr == 2) &&
+ !(MAX_PHY_REG_ADDRESS & reg) &&
+ (data & (1 << 11))) {
WARNING:TYPO_SPELLING: 'retreived' may be misspelled - perhaps 'retrieved'?
#15406: FILE: drivers/net/igc/base/e1000_phy.c:3809:
+ * Reads the PHY register at offset and stores the retreived information
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects?
#16178: FILE: drivers/net/igc/base/e1000_phy.h:152:
+#define BM_PHY_REG(page, reg) \
+ (((reg) & MAX_PHY_REG_ADDRESS) |\
+ (((page) & 0xFFFF) << PHY_PAGE_SHIFT) |\
+ (((reg) & ~MAX_PHY_REG_ADDRESS) << (PHY_UPPER_SHIFT - PHY_PAGE_SHIFT)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects?
#16184: FILE: drivers/net/igc/base/e1000_phy.h:158:
+#define BM_PHY_REG_NUM(offset) \
+ ((u16)(((offset) & MAX_PHY_REG_ADDRESS) |\
+ (((offset) >> (PHY_UPPER_SHIFT - PHY_PAGE_SHIFT)) &\
+ ~MAX_PHY_REG_ADDRESS)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16576: FILE: drivers/net/igc/base/e1000_regs.h:218:
+#define IGC_RDBAL(_n) ((_n) < 4 ? (0x02800 + ((_n) * 0x100)) : \
+ (0x0C000 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16578: FILE: drivers/net/igc/base/e1000_regs.h:220:
+#define IGC_RDBAH(_n) ((_n) < 4 ? (0x02804 + ((_n) * 0x100)) : \
+ (0x0C004 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16580: FILE: drivers/net/igc/base/e1000_regs.h:222:
+#define IGC_RDLEN(_n) ((_n) < 4 ? (0x02808 + ((_n) * 0x100)) : \
+ (0x0C008 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16582: FILE: drivers/net/igc/base/e1000_regs.h:224:
+#define IGC_SRRCTL(_n) ((_n) < 4 ? (0x0280C + ((_n) * 0x100)) : \
+ (0x0C00C + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16584: FILE: drivers/net/igc/base/e1000_regs.h:226:
+#define IGC_RDH(_n) ((_n) < 4 ? (0x02810 + ((_n) * 0x100)) : \
+ (0x0C010 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16586: FILE: drivers/net/igc/base/e1000_regs.h:228:
+#define IGC_RXCTL(_n) ((_n) < 4 ? (0x02814 + ((_n) * 0x100)) : \
+ (0x0C014 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16589: FILE: drivers/net/igc/base/e1000_regs.h:231:
+#define IGC_RDT(_n) ((_n) < 4 ? (0x02818 + ((_n) * 0x100)) : \
+ (0x0C018 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16591: FILE: drivers/net/igc/base/e1000_regs.h:233:
+#define IGC_RXDCTL(_n) ((_n) < 4 ? (0x02828 + ((_n) * 0x100)) : \
+ (0x0C028 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16593: FILE: drivers/net/igc/base/e1000_regs.h:235:
+#define IGC_RQDPC(_n) ((_n) < 4 ? (0x02830 + ((_n) * 0x100)) : \
+ (0x0C030 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16595: FILE: drivers/net/igc/base/e1000_regs.h:237:
+#define IGC_TDBAL(_n) ((_n) < 4 ? (0x03800 + ((_n) * 0x100)) : \
+ (0x0E000 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16597: FILE: drivers/net/igc/base/e1000_regs.h:239:
+#define IGC_TDBAH(_n) ((_n) < 4 ? (0x03804 + ((_n) * 0x100)) : \
+ (0x0E004 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16599: FILE: drivers/net/igc/base/e1000_regs.h:241:
+#define IGC_TDLEN(_n) ((_n) < 4 ? (0x03808 + ((_n) * 0x100)) : \
+ (0x0E008 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16601: FILE: drivers/net/igc/base/e1000_regs.h:243:
+#define IGC_TDH(_n) ((_n) < 4 ? (0x03810 + ((_n) * 0x100)) : \
+ (0x0E010 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16603: FILE: drivers/net/igc/base/e1000_regs.h:245:
+#define IGC_TXCTL(_n) ((_n) < 4 ? (0x03814 + ((_n) * 0x100)) : \
+ (0x0E014 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16606: FILE: drivers/net/igc/base/e1000_regs.h:248:
+#define IGC_TDT(_n) ((_n) < 4 ? (0x03818 + ((_n) * 0x100)) : \
+ (0x0E018 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16608: FILE: drivers/net/igc/base/e1000_regs.h:250:
+#define IGC_TXDCTL(_n) ((_n) < 4 ? (0x03828 + ((_n) * 0x100)) : \
+ (0x0E028 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16610: FILE: drivers/net/igc/base/e1000_regs.h:252:
+#define IGC_TDWBAL(_n) ((_n) < 4 ? (0x03838 + ((_n) * 0x100)) : \
+ (0x0E038 + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_n' - possible side-effects?
#16612: FILE: drivers/net/igc/base/e1000_regs.h:254:
+#define IGC_TDWBAH(_n) ((_n) < 4 ? (0x0383C + ((_n) * 0x100)) : \
+ (0x0E03C + ((_n) * 0x40)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_i' - possible side-effects?
#16620: FILE: drivers/net/igc/base/e1000_regs.h:262:
+#define IGC_RAL(_i) (((_i) <= 15) ? (0x05400 + ((_i) * 8)) : \
+ (0x054E0 + ((_i - 16) * 8)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_i' - possible side-effects?
#16622: FILE: drivers/net/igc/base/e1000_regs.h:264:
+#define IGC_RAH(_i) (((_i) <= 15) ? (0x05404 + ((_i) * 8)) : \
+ (0x054E4 + ((_i - 16) * 8)))
total: 0 errors, 152 warnings, 124 checks, 16869 lines checked
parent reply other threads:[~2020-03-09 8:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1583742247-370386-2-git-send-email-alvinx.zhang@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309085937.463931C01F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=alvinx.zhang@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).