automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw66645 [PATCH v1 3/7] net/virtio: add vectorized packed ring Rx function
       [not found] <20200313174230.74661-4-yong.liu@intel.com>
@ 2020-03-13 10:08 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-03-13 10:08 UTC (permalink / raw)
  To: test-report; +Cc: Marvin Liu

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66645

_coding style issues_


CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#134: FILE: drivers/net/virtio/virtio_rxtx.c:2332:
+virtio_recv_pkts_packed_vec(void __rte_unused *rx_queue,
                                               ^

CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#135: FILE: drivers/net/virtio/virtio_rxtx.c:2333:
+			    struct rte_mbuf __rte_unused **rx_pkts,
 			                                 ^

CHECK:CAMELCASE: Avoid CamelCase: <_Pragma>
#170: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#170: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#170: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#170: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#175: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#175: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#175: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#180: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#180: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#180: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#185: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40:
+#define virtio_for_each_try_unroll(iter, val, num) \
+	for (iter = val; iter < num; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues
#185: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40:
+#define virtio_for_each_try_unroll(iter, val, num) \
+	for (iter = val; iter < num; iter++)

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#272: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:127:
+	__m512i desc_flags = _mm512_set_epi64(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#286: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:141:
+		used_flags = _mm512_set_epi64(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#292: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:147:
+		used_flags = _mm512_set_epi64(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#321: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:176:
+	__m512i vindex = _mm512_set_epi64(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#333: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:188:
+	__m512i mbuf_len_offset = _mm512_set_epi32(

total: 3 errors, 0 warnings, 16 checks, 460 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-13 10:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200313174230.74661-4-yong.liu@intel.com>
2020-03-13 10:08 ` [dpdk-test-report] |WARNING| pw66645 [PATCH v1 3/7] net/virtio: add vectorized packed ring Rx function checkpatch

automatic DPDK test reports

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ https://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git