From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Marvin Liu <yong.liu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw66646 [PATCH v1 4/7] net/virtio: reuse packed ring xmit functions
Date: Fri, 13 Mar 2020 11:08:52 +0100 (CET) [thread overview]
Message-ID: <20200313100852.D5C4A1C0AD@dpdk.org> (raw)
In-Reply-To: <20200313174230.74661-5-yong.liu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66646
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects?
#262: FILE: drivers/net/virtio/virtqueue.h:567:
+#define ASSIGN_UNLESS_EQUAL(var, val) do { \
+ if ((var) != (val)) \
+ (var) = (val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#262: FILE: drivers/net/virtio/virtqueue.h:567:
+#define ASSIGN_UNLESS_EQUAL(var, val) do { \
+ if ((var) != (val)) \
+ (var) = (val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_hdr' - possible side-effects?
#267: FILE: drivers/net/virtio/virtqueue.h:572:
+#define virtqueue_clear_net_hdr(_hdr) do { \
+ ASSIGN_UNLESS_EQUAL((_hdr)->csum_start, 0); \
+ ASSIGN_UNLESS_EQUAL((_hdr)->csum_offset, 0); \
+ ASSIGN_UNLESS_EQUAL((_hdr)->flags, 0); \
+ ASSIGN_UNLESS_EQUAL((_hdr)->gso_type, 0); \
+ ASSIGN_UNLESS_EQUAL((_hdr)->gso_size, 0); \
+ ASSIGN_UNLESS_EQUAL((_hdr)->hdr_len, 0); \
+} while (0)
total: 0 errors, 0 warnings, 3 checks, 349 lines checked
parent reply other threads:[~2020-03-13 10:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200313174230.74661-5-yong.liu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313100852.D5C4A1C0AD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).