From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiayu Hu <jiayu.hu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw66761 [PATCH 3/4] net/vhost: leverage DMA engines to accelerate Tx operations
Date: Tue, 17 Mar 2020 03:44:52 +0100 (CET) [thread overview]
Message-ID: <20200317024452.65B6C1C0C5@dpdk.org> (raw)
In-Reply-To: <1584436885-18651-4-git-send-email-jiayu.hu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66761
_coding style issues_
CHECK:BRACES: Unbalanced braces around else statement
#303: FILE: drivers/net/vhost/rte_eth_vhost.c:735:
+ else {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0'
#618: FILE: drivers/net/vhost/virtio_net.c:54:
+ if ((vhost_need_event(vhost_used_event(vr), new, old) &&
+ (vr->callfd >= 0)) || unlikely(!signalled_used_valid))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0'
#622: FILE: drivers/net/vhost/virtio_net.c:58:
+ if (!(vr->avail->flags & VRING_AVAIL_F_NO_INTERRUPT) &&
+ (vr->callfd >= 0))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects?
#779: FILE: drivers/net/vhost/virtio_net.c:215:
+#define ASSIGN_UNLESS_EQUAL(var, val) do { \
+ if ((var) != (val)) \
+ (var) = (val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#779: FILE: drivers/net/vhost/virtio_net.c:215:
+#define ASSIGN_UNLESS_EQUAL(var, val) do { \
+ if ((var) != (val)) \
+ (var) = (val); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vr' - possible side-effects?
#1372: FILE: drivers/net/vhost/virtio_net.h:35:
+#define vhost_used_event(vr) \
+ (*(volatile uint16_t*)&(vr)->avail->ring[(vr)->size])
total: 0 errors, 0 warnings, 6 checks, 1339 lines checked
parent reply other threads:[~2020-03-17 2:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1584436885-18651-4-git-send-email-jiayu.hu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317024452.65B6C1C0C5@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).