* [dpdk-test-report] |WARNING| pw66785 [PATCH 02/33] net/bnxt: update hwrm prep to use ptr
[not found] <1584459511-5353-3-git-send-email-venkatkumar.duvvuru@broadcom.com>
@ 2020-03-17 15:39 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-03-17 15:39 UTC (permalink / raw)
To: test-report; +Cc: Venkat Duvvuru
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66785
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'req' - possible side-effects?
#131: FILE: drivers/net/bnxt/bnxt_hwrm.c:189:
+#define HWRM_PREP(req, type, kong) do { \
rte_spinlock_lock(&bp->hwrm_lock); \
if (bp->hwrm_cmd_resp_addr == NULL) { \
rte_spinlock_unlock(&bp->hwrm_lock); \
return -EACCES; \
} \
memset(bp->hwrm_cmd_resp_addr, 0, bp->max_resp_len); \
+ (req)->req_type = rte_cpu_to_le_16(type); \
+ (req)->cmpl_ring = rte_cpu_to_le_16(-1); \
+ (req)->seq_id = kong ? rte_cpu_to_le_16(bp->kong_cmd_seq++) :\
+ rte_cpu_to_le_16(bp->chimp_cmd_seq++); \
+ (req)->target_id = rte_cpu_to_le_16(0xffff); \
+ (req)->resp_addr = rte_cpu_to_le_64(bp->hwrm_cmd_resp_dma_addr); \
} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#131: FILE: drivers/net/bnxt/bnxt_hwrm.c:189:
+#define HWRM_PREP(req, type, kong) do { \
rte_spinlock_lock(&bp->hwrm_lock); \
if (bp->hwrm_cmd_resp_addr == NULL) { \
rte_spinlock_unlock(&bp->hwrm_lock); \
return -EACCES; \
} \
memset(bp->hwrm_cmd_resp_addr, 0, bp->max_resp_len); \
+ (req)->req_type = rte_cpu_to_le_16(type); \
+ (req)->cmpl_ring = rte_cpu_to_le_16(-1); \
+ (req)->seq_id = kong ? rte_cpu_to_le_16(bp->kong_cmd_seq++) :\
+ rte_cpu_to_le_16(bp->chimp_cmd_seq++); \
+ (req)->target_id = rte_cpu_to_le_16(0xffff); \
+ (req)->resp_addr = rte_cpu_to_le_64(bp->hwrm_cmd_resp_dma_addr); \
} while (0)
total: 0 errors, 1 warnings, 1 checks, 797 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-17 15:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1584459511-5353-3-git-send-email-venkatkumar.duvvuru@broadcom.com>
2020-03-17 15:39 ` [dpdk-test-report] |WARNING| pw66785 [PATCH 02/33] net/bnxt: update hwrm prep to use ptr checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).