From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw66788 [PATCH 04/33] net/bnxt: add initial tf core session open
Date: Tue, 17 Mar 2020 16:40:12 +0100 (CET) [thread overview]
Message-ID: <20200317154012.2A2641C05C@dpdk.org> (raw)
In-Reply-To: <1584459511-5353-5-git-send-email-venkatkumar.duvvuru@broadcom.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66788
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'parms' - possible side-effects?
#1792: FILE: drivers/net/bnxt/tf_core/tf_msg_common.h:14:
+#define MSG_PREP(parms, mb, type, subtype, req, resp) do { \
+ parms.mailbox = mb; \
+ parms.tf_type = type; \
+ parms.tf_subtype = subtype; \
+ parms.tf_resp_code = 0; \
+ parms.req_size = sizeof(req); \
+ parms.req_data = (uint32_t *)&(req); \
+ parms.resp_size = sizeof(resp); \
+ parms.resp_data = (uint32_t *)&(resp); \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'req' - possible side-effects?
#1792: FILE: drivers/net/bnxt/tf_core/tf_msg_common.h:14:
+#define MSG_PREP(parms, mb, type, subtype, req, resp) do { \
+ parms.mailbox = mb; \
+ parms.tf_type = type; \
+ parms.tf_subtype = subtype; \
+ parms.tf_resp_code = 0; \
+ parms.req_size = sizeof(req); \
+ parms.req_data = (uint32_t *)&(req); \
+ parms.resp_size = sizeof(resp); \
+ parms.resp_data = (uint32_t *)&(resp); \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'resp' - possible side-effects?
#1792: FILE: drivers/net/bnxt/tf_core/tf_msg_common.h:14:
+#define MSG_PREP(parms, mb, type, subtype, req, resp) do { \
+ parms.mailbox = mb; \
+ parms.tf_type = type; \
+ parms.tf_subtype = subtype; \
+ parms.tf_resp_code = 0; \
+ parms.req_size = sizeof(req); \
+ parms.req_data = (uint32_t *)&(req); \
+ parms.resp_size = sizeof(resp); \
+ parms.resp_data = (uint32_t *)&(resp); \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'parms' - possible side-effects?
#1803: FILE: drivers/net/bnxt/tf_core/tf_msg_common.h:25:
+#define MSG_PREP_NO_REQ(parms, mb, type, subtype, resp) do { \
+ parms.mailbox = mb; \
+ parms.tf_type = type; \
+ parms.tf_subtype = subtype; \
+ parms.tf_resp_code = 0; \
+ parms.req_size = 0; \
+ parms.req_data = NULL; \
+ parms.resp_size = sizeof(resp); \
+ parms.resp_data = (uint32_t *)&(resp); \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'resp' - possible side-effects?
#1803: FILE: drivers/net/bnxt/tf_core/tf_msg_common.h:25:
+#define MSG_PREP_NO_REQ(parms, mb, type, subtype, resp) do { \
+ parms.mailbox = mb; \
+ parms.tf_type = type; \
+ parms.tf_subtype = subtype; \
+ parms.tf_resp_code = 0; \
+ parms.req_size = 0; \
+ parms.req_data = NULL; \
+ parms.resp_size = sizeof(resp); \
+ parms.resp_data = (uint32_t *)&(resp); \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'parms' - possible side-effects?
#1814: FILE: drivers/net/bnxt/tf_core/tf_msg_common.h:36:
+#define MSG_PREP_NO_RESP(parms, mb, type, subtype, req) do { \
+ parms.mailbox = mb; \
+ parms.tf_type = type; \
+ parms.tf_subtype = subtype; \
+ parms.tf_resp_code = 0; \
+ parms.req_size = sizeof(req); \
+ parms.req_data = (uint32_t *)&(req); \
+ parms.resp_size = 0; \
+ parms.resp_data = NULL; \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'req' - possible side-effects?
#1814: FILE: drivers/net/bnxt/tf_core/tf_msg_common.h:36:
+#define MSG_PREP_NO_RESP(parms, mb, type, subtype, req) do { \
+ parms.mailbox = mb; \
+ parms.tf_type = type; \
+ parms.tf_subtype = subtype; \
+ parms.tf_resp_code = 0; \
+ parms.req_size = sizeof(req); \
+ parms.req_data = (uint32_t *)&(req); \
+ parms.resp_size = 0; \
+ parms.resp_data = NULL; \
+ } while (0)
ERROR:TRAILING_WHITESPACE: trailing whitespace
#2022: FILE: drivers/net/bnxt/tf_core/tf_session.h:70:
+^I/** $
total: 1 errors, 0 warnings, 7 checks, 2205 lines checked
parent reply other threads:[~2020-03-17 15:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1584459511-5353-5-git-send-email-venkatkumar.duvvuru@broadcom.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317154012.2A2641C05C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=venkatkumar.duvvuru@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).