From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1911A0565 for ; Tue, 17 Mar 2020 16:42:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF8701C07C; Tue, 17 Mar 2020 16:42:01 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id E713C1C0AB; Tue, 17 Mar 2020 16:42:00 +0100 (CET) In-Reply-To: <1584459511-5353-8-git-send-email-venkatkumar.duvvuru@broadcom.com> References: <1584459511-5353-8-git-send-email-venkatkumar.duvvuru@broadcom.com> To: test-report@dpdk.org Cc: Venkat Duvvuru Message-Id: <20200317154200.E713C1C0AB@dpdk.org> Date: Tue, 17 Mar 2020 16:42:00 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw66791 [PATCH 07/33] net/bnxt: add initial tf core resource mgmt support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/66791 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hquery' - possible side-effects? #346: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29: +#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do { \ + if ((dir) == TF_DIR_RX) { \ + if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \ + *(eflag) |= 1 << (hcapi_type); \ + } else { \ + if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \ + *(eflag) |= 1 << (hcapi_type); \ + } \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hcapi_type' - possible side-effects? #346: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29: +#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do { \ + if ((dir) == TF_DIR_RX) { \ + if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \ + *(eflag) |= 1 << (hcapi_type); \ + } else { \ + if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \ + *(eflag) |= 1 << (hcapi_type); \ + } \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eflag' - possible side-effects? #346: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29: +#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do { \ + if ((dir) == TF_DIR_RX) { \ + if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \ + *(eflag) |= 1 << (hcapi_type); \ + } else { \ + if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \ + *(eflag) |= 1 << (hcapi_type); \ + } \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'squery' - possible side-effects? #368: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51: +#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \ + if ((dir) == TF_DIR_RX) { \ + if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\ + *(eflag) |= 1 << (hcapi_type); \ + } else { \ + if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\ + *(eflag) |= 1 << (hcapi_type); \ + } \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hcapi_type' - possible side-effects? #368: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51: +#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \ + if ((dir) == TF_DIR_RX) { \ + if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\ + *(eflag) |= 1 << (hcapi_type); \ + } else { \ + if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\ + *(eflag) |= 1 << (hcapi_type); \ + } \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eflag' - possible side-effects? #368: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51: +#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \ + if ((dir) == TF_DIR_RX) { \ + if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\ + *(eflag) |= 1 << (hcapi_type); \ + } else { \ + if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\ + *(eflag) |= 1 << (hcapi_type); \ + } \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dtype' - possible side-effects? #389: FILE: drivers/net/bnxt/tf_core/tf_rm.c:72: +#define TF_RESC_RSVD(dir, type, dtype) do { \ + if ((dir) == TF_DIR_RX) \ + (dtype) = type ## _RX; \ + else \ + (dtype) = type ## _TX; \ + } while (0) total: 0 errors, 0 warnings, 7 checks, 2339 lines checked