automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Simei Su <simei.su@intel.com>
Subject: [dpdk-test-report] |WARNING| pw66830 [PATCH 3/5] net/iavf: add support for FDIR L2TPv3 and IPSec
Date: Wed, 18 Mar 2020 06:44:29 +0100 (CET)	[thread overview]
Message-ID: <20200318054429.C234D1C036@dpdk.org> (raw)
In-Reply-To: <1584510121-377747-4-git-send-email-simei.su@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66830

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#99: FILE: drivers/net/iavf/iavf_fdir.c:107:
+	{iavf_pattern_eth_ipv4_l2tpv3,		IAVF_FDIR_INSET_L2TPV3OIP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#100: FILE: drivers/net/iavf/iavf_fdir.c:108:
+	{iavf_pattern_eth_ipv6_l2tpv3,		IAVF_FDIR_INSET_L2TPV3OIP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#101: FILE: drivers/net/iavf/iavf_fdir.c:109:
+	{iavf_pattern_eth_ipv4_esp,		IAVF_FDIR_INSET_ESP,			IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#102: FILE: drivers/net/iavf/iavf_fdir.c:110:
+	{iavf_pattern_eth_ipv6_esp,		IAVF_FDIR_INSET_ESP,			IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#103: FILE: drivers/net/iavf/iavf_fdir.c:111:
+	{iavf_pattern_eth_ipv4_ah,		IAVF_FDIR_INSET_AH,			IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#104: FILE: drivers/net/iavf/iavf_fdir.c:112:
+	{iavf_pattern_eth_ipv6_ah,		IAVF_FDIR_INSET_AH,			IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#105: FILE: drivers/net/iavf/iavf_fdir.c:113:
+	{iavf_pattern_eth_ipv4_udp_esp,		IAVF_FDIR_INSET_IPV4_NATT_ESP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#106: FILE: drivers/net/iavf/iavf_fdir.c:114:
+	{iavf_pattern_eth_ipv6_udp_esp,		IAVF_FDIR_INSET_IPV6_NATT_ESP,		IAVF_INSET_NONE},

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.proto_stack.proto_hdr[layer]'
#129: FILE: drivers/net/iavf/iavf_fdir.c:789:
+			hdr = &filter->input.rule_cfg.proto_stack.
+				proto_hdr[layer];

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#136: FILE: drivers/net/iavf/iavf_fdir.c:796:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.proto_stack.proto_hdr[layer]'
#152: FILE: drivers/net/iavf/iavf_fdir.c:812:
+			hdr = &filter->input.rule_cfg.proto_stack.
+				proto_hdr[layer];

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#159: FILE: drivers/net/iavf/iavf_fdir.c:819:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'filter->input.rule_cfg.proto_stack.proto_hdr[layer]'
#175: FILE: drivers/net/iavf/iavf_fdir.c:835:
+			hdr = &filter->input.rule_cfg.proto_stack.
+				proto_hdr[layer];

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#182: FILE: drivers/net/iavf/iavf_fdir.c:842:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(

total: 0 errors, 11 warnings, 3 checks, 121 lines checked

           reply	other threads:[~2020-03-18  5:44 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1584510121-377747-4-git-send-email-simei.su@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318054429.C234D1C036@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=simei.su@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).