From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw67414 [PATCH 4/6] net/sfc/base: refactor mcast filters reconfiguration
Date: Mon, 30 Mar 2020 12:26:33 +0200 (CEST) [thread overview]
Message-ID: <20200330102633.8E7851C0BC@dpdk.org> (raw)
In-Reply-To: <1585563945-9537-5-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67414
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#106: FILE: drivers/net/sfc/base/ef10_filter.c:1854:
+static __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#107: FILE: drivers/net/sfc/base/ef10_filter.c:1855:
+ef10_filter_insert_renew_mulcst_filters(
CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#112: FILE: drivers/net/sfc/base/ef10_filter.c:1860:
+ __in_ecount(6*count) uint8_t const *addrs,
^
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table->eft_using_all_mulcst == B_FALSE'
#153: FILE: drivers/net/sfc/base/ef10_filter.c:1901:
+ if ((table->eft_using_all_mulcst == B_FALSE) &&
+ (encp->enc_bug26807_workaround == B_TRUE)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'encp->enc_bug26807_workaround == B_TRUE'
#153: FILE: drivers/net/sfc/base/ef10_filter.c:1901:
+ if ((table->eft_using_all_mulcst == B_FALSE) &&
+ (encp->enc_bug26807_workaround == B_TRUE)) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#186: FILE: drivers/net/sfc/base/ef10_filter.c:1934:
+ return (rc);
total: 1 errors, 0 warnings, 5 checks, 172 lines checked
parent reply other threads:[~2020-03-30 10:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1585563945-9537-5-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330102633.8E7851C0BC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).